systemd: 249.5 -> 249.7 & various fixes#149153
Merged
flokli merged 6 commits intoNixOS:stagingfrom Dec 7, 2021
Merged
Conversation
It was originally moved because of nixops autoLuks feature which has been unsupported for a while. See: * NixOS#62211 * NixOS/nixops#1156 (comment) systemd-tmpfiles-setup-dev.service needs to run very early (even before udev runs) because udev rules assume static device nodes already exist even before udev is started. If these static device nodes do not exist; systemd might have trouble mounting filesystems that require static device nodes (like loopfs and btrfs).
…rget Since https://github.com/NixOS/nixpkgs/pull/56184/files local-fs.target is already pulled in by sysinit.target swap.target has always already been pulled in by sysinit.target
There is no real harm having them there; but it means these units really only become active if there is a service providing the underlying functionality. nss-lookup.target should not be pulled in unconditionally. It should be pulled in by providers of DNS lookups. E.g. systemd-resolved.service has a Wants=nss-lookup.target, Before=nss-lookup.target. So once systemd-resolved.service has finished starting up; other units that rely on DNS can be started; but if systemd-resolved is not enabled; those units can start up immediately. Same story goes for nss-user-lookup.target and daemons like sssd. From https://systemd.io/UIDS-GIDS/: Note that nss-user-lookup.target is a passive unit: in order to minimize synchronization points on systems that don’t need it the unit is pulled into the initial transaction only if there’s at least one service that really needs it, and that means only if there’s a service providing the local user database somehow through IPC or suchlike.
flokli
reviewed
Dec 7, 2021
| @@ -166,14 +166,6 @@ stdenv.mkDerivation { | |||
| # all our root unit dirs if they are symlinks. This does exactly what we | |||
| # need (AFAICT). | |||
| ./0019-core-handle-lookup-paths-being-symlinks.patch | |||
Member
There was a problem hiding this comment.
Minor nit: We should add a link to systemd/systemd#20479 here, so the PR sent upstream can be found easier.
…ths-being-symlinks.patch
d52d416 to
e2f009e
Compare
10 tasks
Member
|
Let's cook this in staging a bit :-) |
Contributor
|
Should this upgrade the running init process when running rebuild switch? |
Member
|
@yu-re-ka It does: |
Contributor
|
Somehow didn't notice that line, everything is good then :) |
1 task
Contributor
|
Successfully created backport PR #149719 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a rebase version of #121371 + the bump to 249.7
cc @arianvp @flokli
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes