Skip to content

Comments

pamix: fix pending upstream inclusion for ncurses-6.3#148945

Merged
vcunat merged 2 commits intoNixOS:masterfrom
trofi:fix-pamix-for-ncurses-6.3
Dec 15, 2021
Merged

pamix: fix pending upstream inclusion for ncurses-6.3#148945
vcunat merged 2 commits intoNixOS:masterfrom
trofi:fix-pamix-for-ncurses-6.3

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Dec 6, 2021

Without the change the build fails as:

src/pamix_ui.cpp:132:25: error: format not a string literal and no format arguments [-Werror=format-security]
  132 |                 mvprintw(curY, curX + remainingChars + 1, displayName.c_str());
      |                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Without the change the build fails as:

    src/pamix_ui.cpp:132:25: error: format not a string literal and no format arguments [-Werror=format-security]
      132 |                 mvprintw(curY, curX + remainingChars + 1, displayName.c_str());
          |                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@trofi trofi mentioned this pull request Dec 6, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 6, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/uncoming-ncurses-6-2-6-3-update/16169/2

@trofi trofi requested a review from Mic92 December 11, 2021 08:30
@vcunat vcunat merged commit 0158ec8 into NixOS:master Dec 15, 2021
@trofi trofi deleted the fix-pamix-for-ncurses-6.3 branch December 15, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants