Skip to content

escrotum: 2019-06-10 -> 2020-12-07#148910

Merged
thiagokokada merged 1 commit intoNixOS:masterfrom
rasendubi:escrotum-2020-12-07
Dec 6, 2021
Merged

escrotum: 2019-06-10 -> 2020-12-07#148910
thiagokokada merged 1 commit intoNixOS:masterfrom
rasendubi:escrotum-2020-12-07

Conversation

@rasendubi
Copy link
Member

@rasendubi rasendubi commented Dec 6, 2021 •
edited
Loading

Motivation for this change

Requires update to remove python2 dependency. See #148779

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@rasendubi rasendubi mentioned this pull request Dec 6, 2021
Closed
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 6, 2021
@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 6, 2021

Result of nixpkgs-review pr 148910 run on x86_64-linux 1

1 package built:
  • escrotum

thiagokokada
thiagokokada reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work fine.

@thiagokokada thiagokokada merged commit 33e333e into NixOS:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rasendubi @thiagokokada