Skip to content

conway_polynomials, elliptic_curves: use Python 3#148797

Merged
jonringer merged 2 commits intoNixOS:masterfrom
collares:sage-dbs-py2
Dec 6, 2021
Merged

conway_polynomials, elliptic_curves: use Python 3#148797
jonringer merged 2 commits intoNixOS:masterfrom
collares:sage-dbs-py2

Conversation

@collares
Copy link
Member

@collares collares commented Dec 6, 2021 •
edited
Loading

Motivation for this change

#148779

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from 7c6f434c, omasanori and timokau December 6, 2021 01:07
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 6, 2021
@collares
Copy link
Member Author

collares commented Dec 6, 2021

Result of nixpkgs-review pr 148797 run on x86_64-linux 1

4 packages built:
  • conway_polynomials
  • elliptic_curves
  • sage
  • sageWithDoc

jonringer
jonringer approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 148797 run on x86_64-linux 1

4 packages built:
  • conway_polynomials
  • elliptic_curves
  • sage
  • sageWithDoc

@piegamesde piegamesde mentioned this pull request Dec 6, 2021
Closed
@collares collares deleted the sage-dbs-py2 branch December 20, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timokau timokau Awaiting requested review from timokau

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@omasanori omasanori Awaiting requested review from omasanori

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@collares @jonringer