claws-mail: remove claws-mail-gtk2 version#148783
Merged
ajs124 merged 1 commit intoNixOS:masterfrom Dec 6, 2021
Merged
Conversation
The GTK+ 2 version of Claws Mail, major version number three, relies on Python 2, which is end-of-life and might be dropped in the nixpkgs. In favour of NixOS#148779, this older branch of Claws Mail was removed.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
8.has: clean-up
ajs124
approved these changes
Dec 5, 2021
Member
ajs124
left a comment
ajs124
left a comment
There was a problem hiding this comment.
Changes LGTM, but didn't test.
Do you remember why we kept the gtk2 version in the first place?
Member
|
Gtk3 variant was added in b0d9764#diff-d9036335b5ae580ad9137f12608725c778230c2cedcd55638fc1df45ff9f027c |
Member
Author
|
@ajs124: I recall the following, adding to @Artturin's comment:
- First, the then experimental GTK+ 3 version of Claws Mail 3.17.5 was
added as its own derivation; b0d9764.
- Those two packages then both received updates, but of different
quality, and started to diverged.
- Thus, the two packages were merged in
- 553ad19,
- bf92540,
- c2349bf, and
- e37e954.
- With the [double release](https://claws-mail.org/NEWS) of Claws Mail
3.18.0 and the first version of the GTK+ 3 branch, Claws Mail 4.0.0,
the former experimental `claws-mail-gtk3` package became `claws-mail`,
while the other branch became `claws-mail-gtk2`;
26f52bf.
Maybe we should have dropped the old version right away when 4.0.0 was
released, since it probably is not used anyway. Imho, now is the second
best time to clean it up a bit again.
|
Member
Author
|
Result of 2 packages blacklisted:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The GTK+ 2 version of Claws Mail, major version number three, relies on Python 2, which is end-of-life and might be dropped in the nixpkgs.
In favour of #148779, this older branch of Claws Mail was removed.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes