Skip to content

Comments

tcptrack: fix build on ncurses-6.3#148726

Merged
vcunat merged 2 commits intoNixOS:masterfrom
trofi:fix-tcptrack-on-ncurses-6.3
Dec 15, 2021
Merged

tcptrack: fix build on ncurses-6.3#148726
vcunat merged 2 commits intoNixOS:masterfrom
trofi:fix-tcptrack-on-ncurses-6.3

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Dec 5, 2021

Without the change the build fails on ncurses-6.3 as:

TextUI.cc: In member function 'void TextUI::drawui()':
TextUI.cc:312:34: error: format '%d' expects argument of type 'int',
 but argument 2 has type 'time_t' {aka 'long int'} [-Werror=format]
  312 |                         printw("%ds",ic->getIdleSeconds());
      |                                 ~^   ~~~~~~~~~~~~~~~~~~~~
      |                                  int                   time_t {aka long int}
      |                                 %ld

Without the change the build fails on ncurses-6.3 as:

    TextUI.cc: In member function 'void TextUI::drawui()':
    TextUI.cc:312:34: error: format '%d' expects argument of type 'int',
     but argument 2 has type 'time_t' {aka 'long int'} [-Werror=format]
      312 |                         printw("%ds",ic->getIdleSeconds());
          |                                 ~^   ~~~~~~~~~~~~~~~~~~~~
          |                                  int                   time_t {aka long int}
          |                                 %ld
@trofi trofi mentioned this pull request Dec 5, 2021
@ofborg ofborg bot requested review from bjornfor and vrthra December 5, 2021 16:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 5, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/uncoming-ncurses-6-2-6-3-update/16169/2

@trofi trofi requested a review from Mic92 December 11, 2021 08:31
@vcunat vcunat merged commit 826cacf into NixOS:master Dec 15, 2021
@trofi trofi deleted the fix-tcptrack-on-ncurses-6.3 branch December 15, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants