Skip to content

Comments

liboping: fix format arguments for printf()#148623

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:fix-liboping-format
Dec 5, 2021
Merged

liboping: fix format arguments for printf()#148623
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:fix-liboping-format

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Dec 4, 2021

Without the change build fails on ncurses-6.3 as:

oping.c:1601:38: error: too many arguments for format [-Werror=format-extra-args]
1601 | HOST_PRINTF ("%zu bytes from %s (%s): icmp_seq=%u ttl=%i ",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Without the change build fails on `ncurses-6.3` as:

  oping.c:1601:38: error: too many arguments for format [-Werror=format-extra-args]
   1601 |                         HOST_PRINTF ("%zu bytes from %s (%s): icmp_seq=%u ttl=%i ",
        |                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@trofi trofi mentioned this pull request Dec 4, 2021
@ofborg ofborg bot requested a review from bjornfor December 4, 2021 19:08
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 4, 2021
@SuperSandro2000 SuperSandro2000 merged commit 840d3da into NixOS:master Dec 5, 2021
@trofi trofi deleted the fix-liboping-format branch December 5, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants