NixOS/evalModules legacy cleanup#148315
Merged
infinisil merged 6 commits intoNixOS:masterfrom Dec 7, 2021
Merged
Conversation
github-actions
bot
added
6.topic: nixos
12 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
infinisil
approved these changes
Dec 7, 2021
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
Nice cleanup! I can confirm that this fixes specialisations
7 tasks
infinisil
added a commit
to infinisil/nixpkgs
that referenced
this pull request
Dec 10, 2021
Fixes a mistake in NixOS#148315 that caused NixOS#148343 (comment)
13 tasks
12 tasks
1 task
Contributor
|
@roberth @infinisil There is one location remaining in nixpkgs that sets these deprecated Lines 1073 to 1074 in 0ed4113 Could/should this be rewritten? |
Member
|
@nh2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The supposedly legacy
argsflags was still used and was not passed along correctly. This PR fixes this at the module system level, at the NixOS level and in the documentation module. While only one of these would be sufficient to solve the issue, it is clear that we should get rid of the redundant code.First and foremost, address the issue raised in nixos/specialisation: Rephrase in terms of extendModules, noUserModules #144094 (comment).
Deprecate the legacy parameters that, combined with nixos/specialisation: Rephrase in terms of extendModules, noUserModules #144094, created the problem.
Simplify the documentation module and make it more complete and accurate.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes