haskell.compiler.*: use wrapped install_name_tool on aarch64#148116
Merged
sternenseemann merged 1 commit intoNixOS:masterfrom Dec 1, 2021
Merged
haskell.compiler.*: use wrapped install_name_tool on aarch64#148116sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann merged 1 commit intoNixOS:masterfrom
Conversation
sternenseemann
requested review from
cdepillabout,
expipiplus1 and
maralorn
as code owners
github-actions
bot
added
the
6.topic: haskell
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
@ofborg build ghc |
1 similar comment
Member
|
@ofborg build ghc |
Member
|
@NixOS/darwin-maintainers could someone test this on aarch64-darwin? |
Member
Author
|
@fendor has, seems to fix the regression for |
Member
Author
|
Gonna squash the commits and then merge, sound good? |
On aarch64-darwin we have additional wrappers for install_name_tool and strip to deal with codesigning requirements (e. g. updating the signature / checksum after changing a binary). These wrappers don't exist on x86_64-darwin which is why the unwrapped versions were used before, causing the kernel to kill (some) executables produced by GHC.
sternenseemann
force-pushed
the
ghc-aarch6-darwin-use-wrapped
branch
from
f5f5066 to
1b076eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On aarch64-darwin we have an additional wrapper for install_name_tool to
deal with codesigning requirements. Using the unwrapped variant like on
x86_64-darwin would lead to the Setup binary getting killed by the
kernel in builds of haskell packages.
Testing the build of at least
haskellPackages.th-abstractionwould be required.Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes