llvmPackages_13.clang: revert D100879 and re-enable jemalloc for firefox#148107
Merged
vcunat merged 2 commits intoNixOS:staging-nextfrom Dec 15, 2021
Merged
Conversation
The malloc alignment assumption is incorrect for jemalloc and causes mis-compilation in firefox. https://reviews.llvm.org/D100879 https://bugzilla.mozilla.org/show_bug.cgi?id=1741454
ofborg
bot
added
10.rebuild-darwin: 11-100
Contributor
|
Should we backport this to release 21.05 and 21.11 🤔 ? |
Contributor
Author
I have not known that 21.05 also have LLVM 13. But it seems only 21.11 should include this. But let's make this get |
vcunat
approved these changes
Dec 15, 2021
Member
vcunat
left a comment
vcunat
left a comment
There was a problem hiding this comment.
I'm running firefox and thunderbird with this now. The RAM consumption difference is probably practically significant.
The rebuild amount isn't that large, let's at least compromise with staging-next.
Member
|
The PoC does not crash for me. |
1 task
Contributor
|
Successfully created backport PR #150844 for |
rrbutani
added
the
6.topic: llvm/clang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Revert the D100879 which causes #146382, so that we could re-enable
jemallocforfirefoxagain.Currently we disabled
jemallocin #146784 as a temporary workaround. But I found it makesfirefoxconsumes significant more memory. As a simple comparison, I created an empty profile and runfirefoxwith 5 tabs of https://github.com/NixOS/nixpkgs and 5 tabs of https://youtube.com . After loaded and stabilized,firefoxwithoutjemallocconsumes 3.30GiB+-1% RSS, while thejemallocone consumes 2.94GiB+-2% RSS, which is ~10% reduction. (They both don't use any swap space)The test and benchmarks are done by
cherry-picking this PR tomaster.stagingone is still building.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes