Skip to content

Comments

gptfdisk: fix build against upcoming ncurses-6.3#147778

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:fix-gptfdisk-on-ncurses-6.3
Nov 30, 2021
Merged

gptfdisk: fix build against upcoming ncurses-6.3#147778
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:fix-gptfdisk-on-ncurses-6.3

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 28, 2021

On ncurses-6.3 with extra printf() annotations gcc now detects
use of user input in place of format strings:

gptcurses.cc:274:10: error:
    format not a string literal and no format arguments [-Werror=format-security]
  274 |    printw(theLine.c_str());
      |    ~~~~~~^~~~~~~~~~~~~~~~~

On ncurses-6.3 with extra printf() annotations gcc now detects
use of user input in place of format strings:

    gptcurses.cc:274:10: error:
        format not a string literal and no format arguments [-Werror=format-security]
      274 |    printw(theLine.c_str());
          |    ~~~~~~^~~~~~~~~~~~~~~~~
@trofi trofi mentioned this pull request Nov 28, 2021
@ofborg ofborg bot requested a review from a user November 28, 2021 22:28
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Nov 28, 2021
@SuperSandro2000 SuperSandro2000 merged commit db0968b into NixOS:master Nov 30, 2021
@trofi trofi deleted the fix-gptfdisk-on-ncurses-6.3 branch November 30, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants