Skip to content

libretro.pcsx2: init at unstable-2021-11-27#147622

Merged
thiagokokada merged 3 commits intoNixOS:masterfrom
thiagokokada:libretro-pcsx2
Nov 28, 2021
Merged

libretro.pcsx2: init at unstable-2021-11-27#147622
thiagokokada merged 3 commits intoNixOS:masterfrom
thiagokokada:libretro-pcsx2

Conversation

@thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Nov 27, 2021 •
edited
Loading

Motivation for this change

I was having difficult to package this core on #146958, however with the help of @jnetod I finally got it right.

Tested and working.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Nov 27, 2021 •
edited
Loading

Help wanted, it is failing because it can't find the library: http://ix.io/3GhS

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 27, 2021
@ofborg ofborg bot requested review from MP2E, edwtjo and hrdinka November 27, 2021 19:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 27, 2021
@thiagokokada
Copy link
Contributor Author

thiagokokada commented Nov 27, 2021 •
edited
Loading

I tried to list all files from /build directory: http://ix.io/3Gi2

It is not building the libretro_pcsx2.so file for some reason. I think it is missing some cmakeFlags to enable building a library. However I don't have a clue what this flag should be.

I am basing the current cmakeFlags from those:

Also, I tried to use cmake --build instead Makefile too, however it still didn't work (same issue). And cmake --build . --target pcsx2_libretro --config Release doesn't work because pcsx2_libretro is missing.

Edit: @jnetod found the issue. It was missing libaio dependency (and also xxd, however this one is not essential to build it seems). After adding libaio it finally built the pcsx2_libretro.so file.

@thiagokokada thiagokokada marked this pull request as ready for review November 28, 2021 16:33
@thiagokokada
Copy link
Contributor Author

thiagokokada commented Nov 28, 2021 •
edited
Loading

CC @aanderse.

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Nov 28, 2021

Result of nixpkgs-review pr 147622 run on x86_64-linux 1

2 packages built:
  • libretro.pcsx2
  • retroarchFull

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Nov 28, 2021

Tested with Tekken Tag Tournament:

Tekken Tag Tournament (USA) (v2 00)-211128-132952

aanderse
aanderse requested changes Nov 28, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Nov 28, 2021

@aanderse Done.

aanderse
aanderse approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Nov 28, 2021

Result of nixpkgs-review pr 147622 run on x86_64-linux 1

4 packages built:
  • libretro.dolphin
  • libretro.pcsx2
  • libretro.swanstation
  • retroarchFull

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Nov 28, 2021

Result of nixpkgs-review pr 147622 run on x86_64-linux 1

6 packages built:
  • libretro.beetle-saturn
  • libretro.dolphin
  • libretro.flycast
  • libretro.pcsx2
  • libretro.swanstation
  • retroarchFull

@thiagokokada thiagokokada merged commit d6312c2 into NixOS:master Nov 28, 2021
@thiagokokada thiagokokada deleted the libretro-pcsx2 branch November 28, 2021 18:41
@github-actions github-actions bot mentioned this pull request Nov 28, 2021
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2021

Successfully created backport PR #147750 for release-21.11.

@thiagokokada thiagokokada mentioned this pull request Dec 6, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aanderse aanderse aanderse approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

@hrdinka hrdinka Awaiting requested review from hrdinka

@MP2E MP2E Awaiting requested review from MP2E

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thiagokokada @aanderse