bazel_4: Fix Bazel-built protoc segfault on macOS Monterey #147097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config. References: - bazelbuild/bazel#14216 - bazelbuild/bazel#14275
kalbasit
force-pushed
the
bazel_4_fix_on_macos_monterey
branch
from
b474a18 to
dc8d4f3
Compare
uri-canva
approved these changes
Nov 23, 2021
Contributor
|
Change looks good, let's wait for ofborg results, I will also test it locally on Monterey. |
Contributor
|
Tested locally on both |
Member
Author
|
I'll merge it then, thank you @uri-canva. |
1 task
Contributor
|
Successfully created backport PR #147283 for |
1 task
Contributor
|
Successfully created backport PR #147284 for |
mkg20001
pushed a commit
to mkg20001/nixpkgs
that referenced
this pull request
Nov 29, 2021
) This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config. References: - bazelbuild/bazel#14216 - bazelbuild/bazel#14275
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This was fixed by enabling the user_link_flags_feature for macosx cc_toolchain_config.
References:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notescc @Profpatsch @uri-canva @SuperSandro2000