nixos/test-driver: add polling_condition#146905
Conversation
080d0d1 to
5fba0f9
Compare
roberth
left a comment
There was a problem hiding this comment.
This is neat, and should be promoted with some docs :)
|
With this rewrite I'm a lot more confident that this is actually a good idea. What should still happen before this can be merged:
|
eb4e026 to
1326428
Compare
1326428 to
adb9b70
Compare
|
(would really like to merge this to avoid future merge conflicts) |
|
@ofborg test vscodium.wayland |
0ae4c2f to
d633745
Compare
d633745 to
ac6c06c
Compare
|
@ofborg test vscodium.wayland (since I force-pushed this didn't happen I think) |
|
@ofborg test vscodium.wayland vscodium.xorg |
|
Any further objections? Wanna merge this |
|
thank you very much for your patience. the code looks good. as it makes the test driver more complicated with another public interface, i would feel much better having a test that tries to test the polling condition behavior for correctness. can you write one for that, too? we can merge this pull request before and then have another pr for the test to relieve you from the burden of potential rebasing. |
|
A test suite (both unit tests and integration texts) to assure that the
test driver behaves as expected would be nice to have anyways. Definitely
willing to make a start with that
…On Sat, 8 Jan 2022, 13:14 Jacek Galowicz, ***@***.***> wrote:
thank you very much for your patience. the code looks good.
as it makes the test driver more complicated with another public
interface, i would feel much better having a test that tries to test the
polling condition behavior for correctness. can you write one for that,
too? we can merge this pull request before and then have another pr for the
test to relieve you from the burden of potential rebasing.
—
Reply to this email directly, view it on GitHub
<#146905 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABV7PJ7RAIR7HYFVQHCY2HDUVATARANCNFSM5IPL2RHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Motivation for this change
Allows tests to fail early when certain conditions are met. Example with vscodium test provided.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes