Skip to content

Comments

_2048-in-terminal: 2017-11-29 -> 2021-09-12#146878

Merged
thiagokokada merged 1 commit intoNixOS:masterfrom
trofi:fix-_2048-in-terminal-for-ncureses-6.3
Nov 21, 2021
Merged

_2048-in-terminal: 2017-11-29 -> 2021-09-12#146878
thiagokokada merged 1 commit intoNixOS:masterfrom
trofi:fix-_2048-in-terminal-for-ncureses-6.3

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 21, 2021

While at it apply pending ncurses-6.3 fix. Otherwise build fails as:

draw.c:232:9: error: format not a string literal and no format arguments [-Werror=format-security]
  232 |         mvwprintw(board_win, center, left+1, tile_str[val]);
      |         ^~~~~~~~~

While at it apply pending ncurses-6.3 fix. Otherwise build fails as:

    draw.c:232:9: error: format not a string literal and no format arguments [-Werror=format-security]
      232 |         mvwprintw(board_win, center, left+1, tile_str[val]);
          |         ^~~~~~~~~
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 21, 2021
@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 146878 run on x86_64-linux 1

1 package built:
  • _2048-in-terminal

@thiagokokada
Copy link
Contributor

Did a playtest. I clearly suck at this game, but otherwise works fine.

@thiagokokada thiagokokada merged commit 4f871e2 into NixOS:master Nov 21, 2021
@trofi trofi deleted the fix-_2048-in-terminal-for-ncureses-6.3 branch November 21, 2021 20:47
@trofi trofi mentioned this pull request Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants