Skip to content

Comments

nfstrace: pull pending upstream inclusion fix for ncurses-6.3#146469

Merged
Mic92 merged 2 commits intoNixOS:masterfrom
trofi:fix-nfstrace-for-ncurses-6.3
Dec 1, 2021
Merged

nfstrace: pull pending upstream inclusion fix for ncurses-6.3#146469
Mic92 merged 2 commits intoNixOS:masterfrom
trofi:fix-nfstrace-for-ncurses-6.3

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 18, 2021

Without the fix build on ncurses-6.3 fails as:

nfstrace/analyzers/src/watch/nc_windows/header_window.cpp:77:82:
  error: format '%d' expects argument of type 'int', but argument 5 has type 'time_t' {aka 'long int'} [-Werror=format=]
   77 |     mvwprintw(_window, HEADER::ELAPSED_LINE, FIRST_CHAR_POS, "Elapsed time:  \t %d days; %d:%d:%d times",
      |                                                                                 ~^
      |                                                                                  int
      |                                                                                 %ld

While at it dropped blanket -Werror that fails on gcc-12 and clang-12.

Without the fix build on ncurses-6.3 fails as:

    nfstrace/analyzers/src/watch/nc_windows/header_window.cpp:77:82:
      error: format '%d' expects argument of type 'int', but argument 5 has type 'time_t' {aka 'long int'} [-Werror=format=]
       77 |     mvwprintw(_window, HEADER::ELAPSED_LINE, FIRST_CHAR_POS, "Elapsed time:  \t %d days; %d:%d:%d times",
          |                                                                                 ~^
          |                                                                                  int
          |                                                                                 %ld

While at it wropped blnket -Werror that fails on gcc-12 and clang-12.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 18, 2021
@trofi trofi mentioned this pull request Nov 30, 2021
@Mic92 Mic92 merged commit 6829748 into NixOS:master Dec 1, 2021
@trofi trofi deleted the fix-nfstrace-for-ncurses-6.3 branch December 1, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants