util-linux: remove redundant configureFlags#144756
Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom Nov 5, 2021
Merged
util-linux: remove redundant configureFlags#144756SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
Conversation
These programs are both still built even when we don't pass the flags. (It appears that this was not the case when they were added to the expression.)
ofborg
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These programs are both still built even when we don't pass the flags. (It appears that this was not the case when they were added to the expression.)
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)