arrow-cpp: add GCS feature flag#144610
Merged
SuperSandro2000 merged 6 commits intoNixOS:masterfrom Nov 7, 2021
Merged
Conversation
ofborg
bot
added
11.by: package-maintainer
veprbl
added
the
2.status: merge conflict
cpcloud
force-pushed
the
arrow-cpp-gcs
branch
from
2f76ce6 to
37d37c1
Compare
ofborg
bot
removed
the
2.status: merge conflict
veprbl
added
the
2.status: merge conflict
cpcloud
force-pushed
the
arrow-cpp-gcs
branch
from
37d37c1 to
979d73a
Compare
ofborg
bot
removed
the
2.status: merge conflict
cpcloud
force-pushed
the
arrow-cpp-gcs
branch
5 times, most recently
from
4427ea8 to
e0f65a8
Compare
veprbl
reviewed
Nov 7, 2021
veprbl
reviewed
Nov 7, 2021
Member
There was a problem hiding this comment.
Suggested change
| , enableGcs ? true | |
| , enableGcs ? !stdenv.isDarwin # google-cloud-cpp is not supported on darwin |
Contributor
Author
There was a problem hiding this comment.
Is this because of the transitive libnsl dependency (through grpc)?
cpcloud
force-pushed
the
arrow-cpp-gcs
branch
from
e0f65a8 to
cee9436
Compare
Contributor
Author
|
Well, that's fun. It looks like we're hitting this boostorg/process#55. In theory this should build if we use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add GCS support for arrow-cpp.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)