libdeflate: register static build as test (ref: #144207)#144438
Merged
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom Nov 5, 2021
Merged
libdeflate: register static build as test (ref: #144207)#144438SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
SuperSandro2000 merged 3 commits intoNixOS:stagingfrom
Conversation
Contributor
Author
|
I know that static build is broken and I did not fix it yet. I want to make sure that with static build as test CI will fail. |
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Any idea why |
KAction
pushed a commit
to KAction/libdeflate
that referenced
this pull request
Nov 4, 2021
Environment variable DISABLE_SHARED (following convention of --disable-shared of ./configure script) disables building of shared library and shared lib symlink. It makes life of downstream maintainer easier when maintaining package for environment that supports only static libraries. See NixOS/nixpkgs#144438
KAction
force-pushed
the
static/libdeflate
branch
from
2007d9c to
f6cb66b
Compare
Contributor
Author
|
I also added myself as maintainer to get notifications about changes. Do we have concept of "subscribe to particular path in repository"? |
ofborg
bot
added
11.by: package-maintainer
ebiggers
pushed a commit
to ebiggers/libdeflate
that referenced
this pull request
Nov 4, 2021
Environment variable DISABLE_SHARED (following convention of --disable-shared of ./configure script) disables building of shared library and shared lib symlink. It makes life of downstream maintainer easier when maintaining package for environment that supports only static libraries. See NixOS/nixpkgs#144438
added 2 commits
November 5, 2021 05:54
Patch build system to make building of shared libraries optional, and disable it when host system is static.
I am not really interested in maintaining package pe-se, but since static version of it is a dependency of something I care about, I want to subscribe to all changes that can potentially break it.
ofborg
bot
added
10.rebuild-darwin: 0
Member
Only GitHub Codeowners but I think you need commit permissions for that to work. |
Member
There was a problem hiding this comment.
Can we just throw this onto staging to avoid this hackery?
KAction
force-pushed
the
static/libdeflate
branch
from
b9b6c7e to
fd2eefb
Compare
Contributor
Author
|
What is the process to get commit bit? |
Member
|
If you're active enough you can apply through this issue NixOS/nixpkgs-committers#60 |
ofborg
bot
added
10.rebuild-darwin: 501+
Member
Active is not a real hard requirement. I think the only requirements are that you are a trusted member of the community for a reasonable amount of time and you should use the commit bit somewhat regularly and don't be to inactive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix static build of libdeflate
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)