nixos-rebuild: fix --install-bootloader#144429
Conversation
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
Fixes #144007 |
anund
force-pushed
the
nixos-rebuild-fix-install-bootloader
branch
from
be4e2fd to
446e4cc
Compare
|
With #144422 merged to staging should this PR also be shifted to target staging? (how long until staging merges back into master?) |
does this pr depend on that? i dont think so since grub can use this too.
not sure |
|
No dependencies. I'm curious to know if there's a ~simple way to track when fixed systemd + fixed install process would both be available on unstable. At the moment if you are broken and don't want to work with a custom checkout of nix you need both that change and this one to simplify the fix to |
anund
force-pushed
the
nixos-rebuild-fix-install-bootloader
branch
from
446e4cc to
ca36088
Compare
|
@Artturin is there anything left to do but press merge? |
|
Has anyone tested this? For example In a vm after removing the bootloader |
|
Yes, I relied on this fix while testing changes for #144422. I went from non-functional boot loader and back again several times using this PR to verifying the updated systemd + patchset resulted in a working boot-loader. |
nixos-rebuild relies on setting an environment variable to change behaviour during nixos-rebuild boot/switch between calling update or install via systemd bootctl. Adding sudo -- as a prefix to various exec calls does not preserve the environment breaking this mechanism. This is a some what ugly fix that works. Closes NixOS#144429
Artturin
force-pushed
the
nixos-rebuild-fix-install-bootloader
branch
from
ca36088 to
bc5a610
Compare
Artturin
changed the title
nixos-rebuild relies on setting an environment variable to change behaviour during nixos-rebuild boot/switch between calling update or install via systemd bootctl. Adding sudo -- as a prefix to various exec calls does not preserve the environment breaking this mechanism. This is a some what ugly fix that works. Closes NixOS#144429
4 participants
nixos-rebuild relies on setting an environment variable to change
behaviour during nixos-rebuild boot/switch between calling update or
install via systemd bootctl. Adding sudo -- as a prefix to various exec
calls does not preserve the environment breaking this mechanism.
This is a some what ugly fix that works.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)