systemd: fix systemd-boot keyboard handling lockup#144422
Merged
flokli merged 1 commit intoNixOS:stagingfrom Nov 5, 2021
Merged
systemd: fix systemd-boot keyboard handling lockup#144422flokli merged 1 commit intoNixOS:stagingfrom
flokli merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: systemd
Contributor
Author
|
Building the whole world over night to double check the override applied in #143847 isn't somehow wrong when added directly. |
ofborg
bot
added
10.rebuild-darwin: 101-500
Member
|
IIRC, this would need to target staging. |
ofborg
bot
added
the
2.status: merge conflict
Contributor
Author
|
@flokli that's staging in nixpkgs, ya? Somewhat unfamiliar with the branching process here. Preparing a staging based change in the background. |
ofborg
bot
removed
the
2.status: merge conflict
In v248 compiler weirdness and refactoring lead to the bootloader erroring out handling keyboard input on some systems. See systemd/systemd#19191 This should be redundant in v249.6 when it officially gets tagged in systemd-stable. Closes NixOS#143847
Contributor
Author
|
Status: rebuilding on master with this change results in a working systemd-boot process. I required #144429 in order to fix an existing, broken bootloader already on version v249.4. That change or something like it will be required for anyone who is currently broken. |
Member
|
Yes, the staging branch in this repo (nixpkgs). (The reason is that this is a mass rebuild, staging makes it a bit easier on hydra the build farm) |
Contributor
Author
|
👍 It took ~17 hours on a affected laptop to build and test this the master version of this change. |
anund
force-pushed
the
systemd-boot-keyboard-issue
branch
from
df5caae to
d216b21
Compare
anund
requested review from
Ericson2314,
FRidh,
LnL7,
Mic92,
jonringer,
matthewbauer,
stigtsp,
ttuegel and
zakame
as code owners
github-actions
bot
added
6.topic: printing
Contributor
Author
|
:\ sorry everyone, I changed base in the wrong order freaking out the auto tagging/pr action. |
ofborg
bot
added
2.status: merge conflict
Contributor
Author
|
Regarding staging/master. Systemd is on v.249.5 on staging and v249.4 on master so staging is required to avoid merge shenanigans later. |
5 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v248 compiler weirdness and refactoring lead to the bootloader
erroring out handling keyboard input on some systems. This leaves
users on unstable unable to select anything other than the currently
selected generation during a boot.
See systemd/systemd#19191
This should be redundant in v249.6 when it officially gets tagged in
systemd-stable.
Closes #143847
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)