Skip to content

python3Packages.{xdis,uncompyle6}: bump to latest to support python 3.8.12#144059

Merged
SuperSandro2000 merged 2 commits intoNixOS:staging-nextfrom
r-burns:xdis-uncompyle6
Nov 1, 2021
Merged

python3Packages.{xdis,uncompyle6}: bump to latest to support python 3.8.12#144059
SuperSandro2000 merged 2 commits intoNixOS:staging-nextfrom
r-burns:xdis-uncompyle6

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 1, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 1, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 1, 2021
@r-burns
Copy link
Contributor Author

r-burns commented Nov 1, 2021

Result of nixpkgs-review pr 144059 run on x86_64-linux 1

4 packages built:
  • python38Packages.uncompyle6
  • unrpa (python38Packages.unrpa)
  • python38Packages.xdis
  • python39Packages.xdis

@mweinelt
Copy link
Member

mweinelt commented Nov 1, 2021 

/nix/store/x5s5b448m5s9i1hi8n4r24c2f0b0310y-python3.8-xdis-5.0.11/lib/python3.8/site-packages/xdis/op_imports.py:173: in get_opcode_module
    return op_imports[canonic_python_version[vers_str]]
E   KeyError: '3.8.12'

Wow, that is something...

mweinelt
mweinelt requested changes Nov 1, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase onto staging-next so wen can fix the issue there.

@r-burns r-burns changed the base branch from master to staging-next November 1, 2021 19:11
@r-burns
Copy link
Contributor Author

r-burns commented Nov 1, 2021

Sure, done.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 1, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 144059 run on x86_64-linux 1

4 packages built:
  • python38Packages.uncompyle6
  • unrpa (python38Packages.unrpa)
  • python38Packages.xdis
  • python39Packages.xdis

@SuperSandro2000 SuperSandro2000 merged commit 107b7f5 into NixOS:staging-next Nov 1, 2021
@r-burns r-burns deleted the xdis-uncompyle6 branch November 1, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r-burns @mweinelt @SuperSandro2000