Skip to content

Comments

[staging-next] python3Packages.google-cloud-storage: fix build#144027

Merged
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
r-burns:google-cloud-storage
Oct 31, 2021
Merged

[staging-next] python3Packages.google-cloud-storage: fix build#144027
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
r-burns:google-cloud-storage

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 31, 2021

Remove nonexistent disabledTestPath (likely due to merge conflict
between master and python-unstable)

The file is now the same as it is on master

Motivation for this change

For #141684

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-burns
python3Packages.google-cloud-storage: fix build
244ad02 
Remove nonexistent disabledTestPath (likely due to merge conflict
between master and python-unstable)

The file is now the same as it is on master
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 31, 2021
@ofborg ofborg bot requested a review from SuperSandro2000 October 31, 2021 19:36
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 31, 2021
@SuperSandro2000 SuperSandro2000 merged commit 088107e into NixOS:staging-next Oct 31, 2021
@r-burns r-burns deleted the google-cloud-storage branch October 31, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r-burns @SuperSandro2000