nixosTest: Fix infinite recursion involving hasContext testScript whe…#144014
Merged
roberth merged 1 commit intoNixOS:masterfrom Oct 31, 2021
Merged
Conversation
…n useNixStoreImage = true The involved test was nixosTests.nextcloud.basic21. It has a testScript that is strict in nodes.nextcloud.config.system.build.vm, in assertions about imagemagick being in the system closure. The recursion was introduced in 329a446 from NixOS#140792
github-actions
bot
added
the
6.topic: nixos
Member
Author
|
@GrahamcOfBorg build nixosTests.nextcloud nixosTests.gitlab nextcloud: offending evaluation |
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
|
So ofborg has a build failure in these tests, but that doesn't matter. They now evaluate, unblocking the channel. |
Member
Author
|
The tests pass locally, so that's another reason to ignore ofborg's build failures. |
12 tasks
Member
Author
|
Continued discussion: #140792 (comment) |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n useNixStoreImage = true
The involved test was nixosTests.nextcloud.basic21.
It has a testScript that is strict in nodes.nextcloud.config.system.build.vm,
in assertions about imagemagick being in the system closure.
The recursion was introduced in 329a446 from
#140792
Motivation for this change
Unbreak nixos-unstable channel.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)