Skip to content

Comments

[staging-next] librsvg: fix darwin build#143945

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
r-burns:librsvg
Oct 31, 2021
Merged

[staging-next] librsvg: fix darwin build#143945
vcunat merged 1 commit intoNixOS:staging-nextfrom
r-burns:librsvg

Conversation

@r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 31, 2021

Needed now that strictDeps is enabled

Motivation for this change

Fixup #136231
For #141684

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Needed now that strictDeps is enabled
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2021
@ofborg ofborg bot requested review from amaxine, dasj19, hedning and jtojnar October 31, 2021 07:15
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 31, 2021
@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 143945 run on x86_64-darwin 1

226 packages marked as broken and skipped:
  • ajour
  • almanah
  • aravis
  • arcan.arcan
  • arcan.xarcan
  • asymptote
  • atom
  • atom-beta
  • autotrace
  • balsa
  • bespokesynth
  • bluefish
  • btrbk
  • codeblocks
  • codeblocksFull
  • cozy
  • cpupower-gui
  • dasher
  • deluge
  • deluge-2_x
  • devede
  • direwolf
  • enigma
  • equilux-theme
  • exaile
  • faba-icon-theme
  • far2l
  • fast-cli
  • fgallery
  • firefox-esr-78-unwrapped
  • firefox-esr-91-unwrapped
  • firefox-esr-unwrapped
  • firefox-unwrapped
  • firefoxPackages.firefox
  • firefoxPackages.firefox-esr-78
  • firefoxPackages.firefox-esr-91
  • fontpreview
  • foxtrotgps
  • freedroid
  • frescobaldi
  • gcolor3
  • germinal
  • glabels
  • gmic-qt-krita
  • gnome-recipes
  • gnome.eog
  • gnome.gedit
  • gnome.nautilus-python
  • gnomecast
  • gnonograms
  • gnuradio
  • gnuradio3_8
  • gruvbox-dark-icons-gtk
  • gscan2pdf
  • gspeech
  • gtkd
  • gtkmm4
  • helvum
  • hyena
  • ibus-engines.libthai
  • imv
  • invoice2data
  • jabref
  • jumpnbump
  • kicad-small
  • kicad-unstable-small
  • kodi-cli
  • krunner-pass
  • latte-dock
  • lavalauncher
  • libsForQt5.alkimia
  • libsForQt512.alkimia
  • libsForQt514.alkimia
  • libsForQt515.alkimia
  • liquidsoap
  • lounge-gtk-theme
  • lumina.lumina
  • maia-icon-theme
  • mailspring
  • malcontent
  • malcontent-ui
  • marwaita
  • marwaita-manjaro
  • marwaita-peppermint
  • marwaita-pop_os
  • marwaita-ubuntu
  • mat2
  • matcha-gtk-theme
  • mate.atril
  • mate.caja
  • mate.caja-extensions
  • mate.engrampa
  • mate.eom
  • mate.marco
  • mate.mate-control-center
  • mate.mate-icon-theme-faenza
  • mate.mate-indicator-applet
  • mate.mate-media
  • mate.mate-netbook
  • mate.mate-notification-daemon
  • mate.mate-panel
  • mate.mate-power-manager
  • mate.mate-screensaver
  • mate.mate-session-manager
  • mate.mate-settings-daemon
  • mate.mate-system-monitor
  • mate.mate-terminal
  • mate.mate-themes
  • mate.mate-user-guide
  • mate.mate-user-share
  • mate.mate-utils
  • mate.pluma
  • mate.python-caja
  • materia-theme
  • metadata-cleaner
  • mojave-gtk-theme
  • mopidy-musicbox-webclient
  • mousai
  • nheko
  • nwg-wrapper
  • nyxt
  • odpdown
  • onboard
  • paperless-ng
  • pcsx2
  • pcsxr
  • pdfmod
  • perl532Packages.Gtk3ImageView
  • perl532Packages.ImageOCRTesseract
  • perl534Packages.Gtk3ImageView
  • perl534Packages.ImageOCRTesseract
  • picard
  • plano-theme
  • plasma-pass
  • plasma5Packages.alkimia
  • poedit
  • pond
  • pop-icon-theme
  • portmod
  • pragha
  • puppeteer-cli
  • pympress
  • python38Packages.SQLAlchemy-ImageAttach
  • python38Packages.dogtail
  • python38Packages.kivy
  • python38Packages.loo-py
  • python38Packages.mat2
  • python38Packages.paperwork-backend
  • python38Packages.paperwork-shell
  • python38Packages.pyglet
  • python38Packages.pyocr
  • python38Packages.python-vlc
  • python38Packages.pytmx
  • python38Packages.skytemple-ssb-debugger
  • python38Packages.wxPython_4_1
  • python39Packages.SQLAlchemy-ImageAttach
  • python39Packages.dogtail
  • python39Packages.kivy
  • python39Packages.loo-py
  • python39Packages.mat2
  • python39Packages.paperwork-backend
  • python39Packages.paperwork-shell
  • python39Packages.pyglet
  • python39Packages.pyocr
  • python39Packages.python-vlc
  • python39Packages.pytmx
  • python39Packages.skytemple-ssb-debugger
  • python39Packages.wxPython_4_1
  • qogir-theme
  • quassel
  • quasselClient
  • quodlibet
  • quodlibet-full
  • quodlibet-without-gst-plugins
  • quodlibet-xine
  • quodlibet-xine-full
  • radiotray-ng
  • recapp
  • rofi-menugen
  • rootbar
  • run-scaled
  • safeeyes
  • sfizz
  • sharedown
  • shutter
  • sierra-gtk-theme
  • skeu
  • skytemple
  • spek
  • sublime-music
  • surf
  • sway-contrib.grimshot
  • syncthing-gtk
  • sysprof
  • termite
  • termite-unwrapped
  • tev
  • thunderbird-78-unwrapped
  • thunderbird-unwrapped
  • thunderbirdPackages.thunderbird
  • thunderbirdPackages.thunderbird-78
  • udiskie
  • uget
  • uim
  • venta
  • vimix-gtk-themes
  • virt-manager-qt
  • waybar
  • wayfireApplications-unwrapped.wcm
  • wcm
  • whitesur-gtk-theme
  • wine64
  • wine64Packages.full
  • xarchiver
  • xfce.xfce4-hardware-monitor-plugin
  • xfce.xfce4-i3-workspaces-plugin
  • xfce.xfce4-sensors-plugin
  • xfce.xfce4-weather-plugin
  • xfce.xfce4-windowck-plugin
  • xfce.xfce4_hardware_monitor_plugin
  • xfce.xfce4_sensors_plugin
  • xfce.xfce4_weather_plugin
  • xfce.xfce4_windowck_plugin
  • xulrunner
  • yaxg
  • zim
329 packages failed to build:
  • aerc
  • afew
  • agdaPackages.agda-categories
  • agdaPackages.agda-prelude
  • agdaPackages.agdarsec
  • agdaPackages.cubical
  • agdaPackages.functional-linear-algebra
  • agdaPackages.standard-library
  • arandr
  • ffmpeg-full (arcan.ffmpeg)
  • ario
  • asc-key-to-qr-code-gif
  • asciidoc-full
  • asciidoc-full-with-plugins
  • auctex
  • awf
  • ballerburg
  • banking
  • bleachbit
  • blockhash
  • caerbannog
  • calibre-web
  • cask
  • castor
  • cataract
  • cataract-unstable
  • cd-hit
  • cflow
  • chafa
  • cm-rgb
  • compcert (coqPackages.compcert)
  • coq (coqPackages.coq ,coq_8_13)
  • coqPackages.Cheerios
  • coqPackages.CoLoR
  • coqPackages.ITree
  • coqPackages.InfSeqExt
  • coqPackages.QuickChick
  • coqPackages.StructTact
  • coqPackages.VST
  • coqPackages.Verdi
  • coqPackages.aac-tactics
  • coqPackages.addition-chains
  • coqPackages.autosubst
  • coqPackages.bignums
  • coqPackages.category-theory
  • coqPackages.ceres
  • coqPackages.coq-bits
  • coqPackages.coq-elpi
  • coqPackages.coq-ext-lib
  • coqPackages.coqeal
  • coqPackages.coqhammer
  • coqPackages.coqprime
  • coqPackages.coqtail-math
  • coqPackages.coquelicot
  • coqPackages.corn
  • coqPackages.deriving
  • coqPackages.dpdgraph
  • coqPackages.equations
  • coqPackages.extructures
  • coqPackages.flocq
  • coqPackages.fourcolor
  • coqPackages.gaia
  • coqPackages.gaia-hydras
  • coqPackages.gappalib
  • coqPackages.goedel
  • coqPackages.graph-theory
  • coqPackages.hierarchy-builder
  • coqPackages.hydra-battles
  • coqPackages.interval
  • coqPackages.iris
  • coqPackages.itauto
  • coqPackages.math-classes
  • coqPackages.mathcomp
  • coqPackages.mathcomp-abel
  • coqPackages.mathcomp-algebra
  • coqPackages.mathcomp-analysis
  • coqPackages.mathcomp-bigenough
  • coqPackages.mathcomp-character
  • coqPackages.mathcomp-field
  • coqPackages.mathcomp-fingroup
  • coqPackages.mathcomp-finmap
  • coqPackages.mathcomp-real-closed
  • coqPackages.mathcomp-solvable
  • coqPackages.ssreflect (coqPackages.mathcomp-ssreflect)
  • coqPackages.mathcomp-tarjan
  • coqPackages.mathcomp-zify
  • coqPackages.metalib
  • coqPackages.multinomials
  • coqPackages.odd-order
  • coqPackages.paco
  • coqPackages.paramcoq
  • coqPackages.parsec
  • coqPackages.pocklington
  • coqPackages.reglang
  • coqPackages.relation-algebra
  • coqPackages.semantics
  • coqPackages.serapi
  • coqPackages.simple-io
  • coqPackages.stdpp
  • coqPackages.tlc
  • coqPackages.topology
  • coqPackages.zorns-lemma
  • coq_8_10
  • coq_8_11
  • coq_8_12
  • coq_8_14
  • corrscope
  • cscope
  • darktable
  • dblatexFull
  • deltachat-cursed
  • dino
  • djview (djview4)
  • djvu2pdf
  • djvulibre
  • dmtx-utils
  • dvdauthor
  • electrum
  • emacs (emacs27)
  • fitnesstrax
  • font-manager
  • framac
  • fsearch
  • gammastep
  • gcstar
  • geany
  • gegl
  • genxword
  • geoclue2
  • gimp (gimpPlugins.gimp)
  • gimpPlugins.gmic (glimpsePlugins.gmic)
  • glimpse (glimpsePlugins.gimp)
  • gnome-icon-theme (gnome2.gnome-icon-theme ,gnome2.gnome_icon_theme ,gnome2.gnomeicontheme)
  • gnome-podcasts
  • gnome.defaultIconTheme (gnome.adwaita-icon-theme)
  • gnome.ghex
  • librsvg (gnome.librsvg)
  • meld (gnome.meld)
  • webkitgtk (gnome.webkitgtk)
  • gnudatalanguage
  • gnumeric
  • gnvim
  • gnvim-unwrapped
  • goattracker
  • goattracker-stereo
  • gobby
  • goffice
  • gopro
  • gpodder
  • gpscorrelate
  • gramps
  • gssdp-tools
  • gst_all_1.gst-editing-services
  • gst_all_1.gst-plugins-bad
  • gst_all_1.gst-rtsp-server
  • gtk-pipe-viewer
  • gtk4
  • gtksourceview5
  • hamster
  • handbrake
  • haskellPackages.Agda
  • haskellPackages.ghc-vis
  • haskellPackages.gi-javascriptcore
  • haskellPackages.gi-webkit2
  • haskellPackages.gi-webkit2webextension
  • haskellPackages.hbro
  • haskellPackages.hbro-contrib
  • haskellPackages.notmuch
  • haskellPackages.svgcairo
  • haskellPackages.zbar
  • humanity-icon-theme
  • iconnamingutils
  • image-roll
  • imagemagick
  • imagemagick6
  • imagemagick6Big
  • imagemagickBig
  • imgproxy
  • inkscape
  • inkscape-extensions.applytransforms
  • inkscape-with-extensions
  • invidious
  • joplin
  • jwm
  • rep (kakounePlugins.rep)
  • kitty
  • ldgallery
  • libhandy
  • libpst
  • libsForQt5.libopenshot (libsForQt512.libopenshot)
  • libsForQt514.libopenshot
  • libsForQt515.libopenshot (plasma5Packages.libopenshot)
  • libwmf
  • lieer
  • lilypond
  • lilypond-with-fonts
  • links2
  • lsix
  • luakit
  • manim
  • mapserver
  • mars-mips
  • mate.mozo
  • mcomix3
  • mikutter
  • mindforger
  • mlterm
  • mopidy-iris
  • mopidy-local
  • mopidy-mopify
  • mopidy-mpd
  • mopidy-mpris
  • mopidy-podcast
  • mopidy-scrobbler
  • mopidy-somafm
  • mopidy-soundcloud
  • mopidy-spotify-tunigo
  • mopidy-subidy
  • mopidy-tunein
  • mopidy-youtube
  • mopidy-ytmusic
  • mpdris2
  • mu
  • muchsync
  • muso
  • neomutt
  • netbeans
  • newsflash
  • nicotine-plus
  • nip2
  • nix-query-tree-viewer
  • noteshrink
  • notmuch
  • notmuch-addrlookup
  • noto-fonts-emoji
  • numberstation
  • numix-cursor-theme
  • olive-editor
  • onioncircuits
  • openshot-qt
  • openspades
  • pdf-redact-tools
  • pdf2odt
  • pdfpc
  • pdfsam-basic
  • pdftag
  • perl532Packages.BarcodeZBar
  • perl532Packages.PerlMagick (perl532Packages.ImageMagick)
  • perl532Packages.LaTeXML
  • perl534Packages.BarcodeZBar
  • perl534Packages.PerlMagick (perl534Packages.ImageMagick)
  • perl534Packages.LaTeXML
  • phash
  • pict-rs
  • pithos
  • pstoedit
  • pycflow2dot (python39Packages.pycflow2dot)
  • pydb
  • python38Packages.Wand
  • python38Packages.diagrams
  • python38Packages.inkex
  • python38Packages.notmuch
  • python38Packages.notmuch2
  • python38Packages.pycflow2dot
  • python38Packages.pydub
  • python38Packages.pyvips
  • python38Packages.pywal
  • python38Packages.recoll
  • python38Packages.xdot
  • python39Packages.Wand
  • python39Packages.diagrams
  • python39Packages.inkex
  • python39Packages.notmuch
  • python39Packages.notmuch2
  • python39Packages.pydub
  • python39Packages.pyvips
  • pywal (python39Packages.pywal)
  • recoll (python39Packages.recoll)
  • xdot (python39Packages.xdot)
  • qalculate-gtk
  • qutebrowser
  • racket
  • racket-minimal
  • rednotebook
  • redshift
  • redshift-wlr
  • ripgrep-all
  • rpiplay
  • rtags
  • rubyPackages.atk (rubyPackages_2_7.atk)
  • rubyPackages.gdk_pixbuf2 (rubyPackages_2_7.gdk_pixbuf2)
  • rubyPackages.gio2 (rubyPackages_2_7.gio2)
  • rubyPackages.gobject-introspection (rubyPackages_2_7.gobject-introspection)
  • rubyPackages.gtk2 (rubyPackages_2_7.gtk2)
  • rubyPackages.pango (rubyPackages_2_7.pango)
  • rubyPackages.rmagick (rubyPackages_2_7.rmagick)
  • rubyPackages.ruby-vips (rubyPackages_2_7.ruby-vips)
  • rubyPackages_3_0.atk
  • rubyPackages_3_0.gdk_pixbuf2
  • rubyPackages_3_0.gio2
  • rubyPackages_3_0.gobject-introspection
  • rubyPackages_3_0.gtk2
  • rubyPackages_3_0.pango
  • rubyPackages_3_0.rmagick
  • rubyPackages_3_0.ruby-vips
  • sayonara
  • scenebuilder
  • setzer
  • sfxr
  • sourcetrail
  • sqlitebrowser
  • stlink-gui
  • stm32cubemx
  • t-rec
  • termplay
  • timelapse-deflicker
  • transmission-gtk
  • tryton
  • ttygif
  • vcs
  • vips
  • webkitgtk_4_1
  • why3
  • wike
  • wv
  • xboard
  • yubikey-personalization-gui
  • zathura
  • zbar

Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@happysalada
Copy link
Contributor

@r-burns the fix looks reasonable, I have no idea why my nixpkgs-review completely failed.

@vcunat vcunat merged commit 1526c99 into NixOS:staging-next Oct 31, 2021
@vcunat
Copy link
Member

vcunat commented Oct 31, 2021

Uh, you checked x86_64-darwin? There librsvg didn't build on Hydra because of a dependency: https://hydra.nixos.org/build/156658115 Either way, I hope this PR (also) solves the aarch64-darwin build.

@r-burns r-burns deleted the librsvg branch October 31, 2021 17:18
@r-burns
Copy link
Contributor Author

r-burns commented Oct 31, 2021

Hmm, I did, and I didn't get that failure locally.

@vcunat
Copy link
Member

vcunat commented Nov 1, 2021

It succeeded on Hydra as well: https://hydra.nixos.org/build/157179140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants