[staging-next] librsvg: fix darwin build#143945
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Oct 31, 2021
Merged
Conversation
Needed now that strictDeps is enabled
Contributor
|
Result of 226 packages marked as broken and skipped:
329 packages failed to build:
|
Contributor
|
@r-burns the fix looks reasonable, I have no idea why my nixpkgs-review completely failed. |
Member
|
Uh, you checked |
Contributor
Author
|
Hmm, I did, and I didn't get that failure locally. |
Member
|
It succeeded on Hydra as well: https://hydra.nixos.org/build/157179140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed now that strictDeps is enabled
Motivation for this change
Fixup #136231
For #141684
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)