xmonad: Don't add ghc to the closure when 'config' is set#143886
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Nov 22, 2021
Merged
xmonad: Don't add ghc to the closure when 'config' is set#143886SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
When 'services.xserver.windowManager.xmonad.config' is not null, the restart feature won't work by default and is not desirable unless specific care is made, as explained by the documentation. I think it's reasonable to not include the haskell dependencies in the environment by default. That reduces the size of my system by 2GB.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
xaverdh
approved these changes
Oct 31, 2021
Contributor
xaverdh
left a comment
xaverdh
left a comment
There was a problem hiding this comment.
Not tested, but looks good to me.
Still I am curious, do you actually build your system on a machine different from the one you run xmonad on?
Contributor
Author
|
I actually do that for a small computer plugged to my TV, which I use only for streaming services. I build the system on my main computer, Otherwise, it's mainly for the satisfaction of trimming down the system and removing mutable parts. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When 'services.xserver.windowManager.xmonad.config' is not null, the
restart feature won't work by default and is not desirable unless
specific care is made, as explained by the documentation.
I think it's reasonable to not include the haskell dependencies in the
environment by default. That reduces the size of my system by 2GB.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)