Skip to content

Comments

Revert "coreutils: 8.32 -> 9.0" for darwin only#142836

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
happysalada:staging-next
Oct 25, 2021
Merged

Revert "coreutils: 8.32 -> 9.0" for darwin only#142836
mweinelt merged 1 commit intoNixOS:staging-nextfrom
happysalada:staging-next

Conversation

@happysalada
Copy link
Contributor

@happysalada happysalada commented Oct 25, 2021 •
edited
Loading

This reverts coreutils upgrade just for darwin.

For more information see the details on #141684 (comment)

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada happysalada mentioned this pull request Oct 25, 2021
Merged
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 25, 2021

Please copy the coreutils file from version 8.32 and copy it into a separate file and then we give that darwin so that we can keep the 9.0 for linux.

@happysalada
Copy link
Contributor Author

happysalada commented Oct 25, 2021

I've only reverted the change for darwin.
Waiting for the CI just to make sure ti didn't screw up anything.

@happysalada happysalada changed the title Revert "coreutils: 8.32 -> 9.0" Revert "coreutils: 8.32 -> 9.0" for darwin only Oct 25, 2021
SuperSandro2000
SuperSandro2000 reviewed Oct 25, 2021
View reviewed changes
@mweinelt mweinelt requested a review from dasJ October 25, 2021 13:23
dasJ
dasJ approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a lot better than downgrading for Linux as well

@mweinelt mweinelt merged commit 3db3126 into NixOS:staging-next Oct 25, 2021
@happysalada happysalada deleted the staging-next branch October 25, 2021 13:37
@vcunat vcunat mentioned this pull request Oct 25, 2021
Merged
12 tasks
@dasJ dasJ mentioned this pull request Oct 27, 2021
Closed
@r-burns
Copy link
Contributor

r-burns commented Oct 30, 2021

@happysalada now that we have disabled SEEK_HOLE, would you be able to check if we can un-revert this on darwin? I would myself but I wasn't able to reproduce any of the darwin issues on my end.

@happysalada
Copy link
Contributor Author

happysalada commented Oct 30, 2021

@r-burns happy to help, but what is it that needs testing ?
I've tested #139541 on darwin and it all went fine. (that PR uses 9.0 on darwin as well).
Do you mean to give staging-next one last test ?

@r-burns
Copy link
Contributor

r-burns commented Oct 30, 2021

I'm referring to testing the go/rust issues we didn't notice originally, but you noticed on staging-next that resulted in this revert. I didn't encounter those myself but if you can confirm that they're no longer an issue, we can un-revert this, right?

@happysalada
Copy link
Contributor Author

happysalada commented Oct 30, 2021 •
edited
Loading

originally PR #143097 switched coreutils for darwin as well. I had tested the rust issuer with that PR.
I just double checked again though and it seems that PR doesn't do anything to darwin.
Let me make a PR.

@happysalada
Copy link
Contributor Author

happysalada commented Oct 30, 2021

opened a PR, currently testing it
#143800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@dasJ dasJ dasJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@happysalada @SuperSandro2000 @r-burns @dasJ @mweinelt