Skip to content

NixOS: Document impurity issues with boot.binfmt.emulatedSystems#142778

Merged
markuskowa merged 6 commits intoNixOS:masterfrom
ck3d:doc-cross-impurity
Nov 9, 2021
Merged

NixOS: Document impurity issues with boot.binfmt.emulatedSystems#142778
markuskowa merged 6 commits intoNixOS:masterfrom
ck3d:doc-cross-impurity

Conversation

@ck3d
Copy link
Contributor

@ck3d ck3d commented Oct 24, 2021

Motivation for this change

For cross compiled packages, we have to take care boot.binfmt.emulatedSystems is not set. This PR adds more some note to the NixOS option.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 24, 2021
@ck3d ck3d mentioned this pull request Oct 24, 2021
Merged
12 tasks
@nrdxp
Copy link

nrdxp commented Oct 25, 2021

Result of nixpkgs-review pr 142778 run on x86_64-linux 1

1 package failed to build:
  • nixos-install-tools

SuperSandro2000
SuperSandro2000 reviewed Oct 26, 2021
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 27, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 28, 2021

I think this is LGTM but I would appreciate if a native speaker could prove read it.

mohe2015
mohe2015 reviewed Oct 29, 2021
View reviewed changes
markuskowa
markuskowa reviewed Nov 1, 2021
View reviewed changes
markuskowa
markuskowa reviewed Nov 1, 2021
View reviewed changes
@ck3d ck3d requested a review from dasJ as a code owner November 9, 2021 20:37
@markuskowa markuskowa merged commit 33ffba9 into NixOS:master Nov 9, 2021
SuperSandro2000
SuperSandro2000 reviewed Nov 9, 2021
View reviewed changes
nixos/modules/system/boot/binfmt.nix
description = ''
List of systems to emulate. Will also configure Nix to
support your new systems.
Warning: the builder can execute all emulated systems within the same build, which introduces impurities in the case of cross compilation.
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Warning: the builder can execute all emulated systems within the same build, which introduces impurities in the case of cross compilation.
Warning: the builder can execute all emulated systems within the same build, which can introduce impurities in the case of cross compilation.

Copy link
Contributor Author

@ck3d ck3d Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely does introduce impurity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@markuskowa markuskowa markuskowa left review comments

@dasJ dasJ Awaiting requested review from dasJ

+1 more reviewer

@mohe2015 mohe2015 mohe2015 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ck3d @nrdxp @SuperSandro2000 @mohe2015 @markuskowa