Skip to content

gcc11: 11.1.0 -> 11.2.0#142684

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
bobrik:ivan/gcc-11.2.0
Oct 27, 2021
Merged

gcc11: 11.1.0 -> 11.2.0#142684
vcunat merged 1 commit intoNixOS:stagingfrom
bobrik:ivan/gcc-11.2.0

Conversation

@bobrik
Copy link
Contributor

@bobrik bobrik commented Oct 23, 2021 •
edited by vcunat
Loading

Motivation for this change

The cyclades patch has been applied upstream:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@bobrik
gcc11: 11.1.0 -> 11.2.0
e8abd9c 
The cyclades patch has been applied upstream:

* gcc-mirror/gcc@2bf34b9f4e4
@bobrik bobrik requested a review from matthewbauer as a code owner October 23, 2021 19:13
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 23, 2021
@fabianhjr
Copy link
Member

fabianhjr commented Oct 23, 2021

Since most derivations currently use gcc10 it seems like this could safely go directly to the main branch without a mass rebuild. :3

@bobrik
Copy link
Contributor Author

bobrik commented Oct 23, 2021

GCC 11 is the default GCC for aarch64-darwin.

@r-burns r-burns mentioned this pull request Oct 23, 2021
Closed
@fabianhjr
Copy link
Member

fabianhjr commented Oct 23, 2021 •
edited
Loading

Builds and runs on x86_64-linux (NixOS):

/nix/store/22x3wqwhc61r31xb8j85haqncy7p1p9y-gcc-wrapper-11.2.0/bin/gcc --version
gcc (GCC) 11.2.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@vcunat
Copy link
Member

vcunat commented Oct 24, 2021

The rebuild amount is surprisingly high to me:

Estimating rebuild amount by counting changed Hydra jobs (parallel=unset).
  10320 aarch64-darwin

but minor gcc updates should be fairly safe wrt. breaking changes. I'd personally think that going directly for staging-next would be OK at this point, but I expect there's no need to hurry.

SuperSandro2000
SuperSandro2000 reviewed Oct 24, 2021
View reviewed changes
@bobrik
Copy link
Contributor Author

bobrik commented Oct 24, 2021

The rebuild amount is surprisingly high to me

  • 2648 packages depend on numpy (which in turn depends on gfortran, supplied by gcc)
  • 7215 packages depend on ghc (which in turn depends on binary ghc, which depends on gcc)

@vcunat vcunat merged commit 2489900 into NixOS:staging Oct 27, 2021
@bobrik bobrik deleted the ivan/gcc-11.2.0 branch December 4, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@vcunat vcunat Awaiting requested review from vcunat

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobrik @fabianhjr @vcunat @SuperSandro2000