haskellPackages: update stackage and hackage#142641
Merged
cdepillabout merged 41 commits intomasterfrom Nov 5, 2021
Merged
Conversation
This commit has been generated by maintainers/scripts/haskell/update-hackage.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
expipiplus1
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
8.has: package (new)
Allows vector to be built with ghcjs
Unbreak packages: aeson-via, diagrams-canvas and hw-prim-bits
ghcjs: remove duplicate vector patch
Contributor
Author
Fails to compile with stackage's brick version and additionally depends on packages depending on brick, so overrideScope is necessary. Should be fine as this is a leaf package.
Member
|
|
haskellPackages.tasty-checklist: unbreak
GHC 9.2.1 seemingly has trouble decoding the UTF-8 in tf-random's haddock comments and cabal file, causing haddock and the build to fail. Until there's a patch from upstream we can apply, we'll just disable haddock.
Member
|
@rvl Can we upgrade electron for |
Member
haskell-updates build report from hydraevaluation 1718485 of nixpkgs commit cf8d672 as of 2021-11-03 00:37 UTC 🔴 Branch not mergeable
Build summary
Maintained packages with failed dependency
Unmaintained packages with build failure87 job(s)
Unmaintained packages with failed dependency67 job(s)
Top 50 broken packages, sorted by number of reverse dependencies50 job(s)haskell98 Report generated with maintainers/scripts/haskell/hydra-report.hs |
Member
|
Looks like there are some In talking to @sternenseemann, we decided it might be alright to ignore the ghc921 problems on aarch64 for now (since there isn't a fix upstream yet??), but if anyone wants to look into it, it would of course be appreciated. |
Member
I don't think there's much we can do about it, except maybe bisecting GHC (ugh) between 9.2.1-rc1 and 9.2.1 proper. GHC upstream knows about the problem and is looking into it, as far as I can tell. |
Member
|
A lot of stuff has fixed itself either via restart or a regression being adressed in master. The remaining failures have either been introduced in master (nokogiri on darwin) or are beyond our power for now (GHC 9.2.1 on aarch64-linux). For GHC 9.2.1, we could work around the issue, but I'm not sure if disabling test suites that fail because of a buggy |
Member
|
I'm going to go ahead and merge this in. Like sternenseemann said, the 9.2.1 stuff doesn't appear to be fixed upstream yet, and the OSX errors appear to also be happening on |
Contributor
Author
|
Thanks, @cdepillabout! |
This commit has been generated by maintainers/scripts/haskell/mark-broken.sh
ofborg
bot
added
the
8.has: clean-up
hyper-haskell depends on electron-10.4.7, which is marked insecure.
Member
|
@rvl I've marked If this breaks your workflow, please feel free to ping me on a PR to |
Member
Don't quite agree with that: Marking it as broken changes the error message in an inaccurate way: The package builds fine, but uses an insecure dependency and that should be communicated to the user. To get rid of the eval error, adding it to |
Member
|
@sternenseemann That's a good point. I'll put together a PR targeting |
Member
I took a look at this, and So adding the top-level I guess the only thing that needs to happen now is to unmark it as broken, since it is not really broken, just relying on unsecure packages: |
Member
|
IMO just having the slight noise in the eval output would be fine. |
sternenseemann
added a commit
that referenced
this pull request
Nov 15, 2021
This was incorrect: #142641 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Merge
This PR is the regular merge of the
haskell-updatesbranch intomaster.This branch is being continually built and tested by hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. You may be able to find an up-to-date Hydra build report at cdepillabout/nix-haskell-updates-status.
We roughly aim to merge these
haskell-updatesPRs at least once every two weeks. See the @NixOS/haskell team calendar for who is currently in charge of this branch.haskellPackages Workflow Summary
Our workflow is currently described in
pkgs/development/haskell-modules/HACKING.md.The short version is this:
haskell-updates(normally at the beginning of a merge window).haskell-updatesintomasterevery two weeks.mergeablejob is succeeding on hydra.maintainedpackage is still broken at the time of merge, we will only merge if the maintainer has been pinged 7 days in advance. (If you care about a Haskell package, become a maintainer!)This is the follow-up to #142094. Come to #haskell:nixos.org if you have any questions.