Skip to content

NixOps test#142035

Merged
roberth merged 3 commits intoNixOS:masterfrom
hercules-ci:nixops-test
Oct 18, 2021
Merged

NixOps test#142035
roberth merged 3 commits intoNixOS:masterfrom
hercules-ci:nixops-test

Conversation

@roberth
Copy link
Member

@roberth roberth commented Oct 17, 2021 •
edited
Loading

Motivation for this change

Detect when nixops breaks.

cc @adisbladis for NixOps
cc @tfc for nixos vm testing system.build.networkConfig addition

Closes #97166

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@roberth roberth requested review from adisbladis and tfc October 17, 2021 22:43
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 17, 2021
@roberth roberth added the 6.topic: testing Tooling for automated testing of packages and modules label Oct 17, 2021
@roberth roberth mentioned this pull request Oct 17, 2021
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 17, 2021
tfc
tfc approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@tfc tfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only have two little nitpicks

@roberth roberth changed the title Nixops test NixOps test Oct 18, 2021
@roberth roberth merged commit 6dfab18 into NixOS:master Oct 18, 2021
collares
collares reviewed Oct 31, 2021
View reviewed changes
nixos/tests/nixops/default.nix
users.users.person.isNormalUser = true;
virtualisation.writableStore = true;
virtualisation.memorySize = 1024 /*MiB*/;
virtualisation.pathsInNixDB = [
Copy link
Member

@collares collares Oct 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was since renamed (in #140792) to virtualisation.additionalPaths.

Copy link
Member Author

@roberth roberth Oct 31, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PRs overlapped, so I couldn't apply the change in advance. Thanks for the reminder. Opened #143993.

This was referenced Nov 18, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@collares collares collares left review comments

@tfc tfc tfc approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add NixOps test

3 participants

@roberth @tfc @collares