pantheon: manage user session with systemd by bobby285271 · Pull Request #140429 · NixOS/nixpkgs

bobby285271 · 2021-10-04T02:17:27Z

Motivation for this change

Fixes #101817

Things done

Built on platform(s)
- x86_64-linux
Fits CONTRIBUTING.md.

davidak · 2021-10-04T02:37:15Z

Is this ready to test? Asking because it's marked as draft.

bobby285271 · 2021-10-04T02:40:53Z

Yes, I am using this on my physical machine.

@ofborg test pantheon

pkgs/desktops/pantheon/desktop/gala/default.nix

davidak · 2021-12-02T01:31:07Z

nixos/modules/services/x11/desktop-managers/pantheon.nix

does it make sense to have both?

davidak · 2021-12-02T01:35:54Z

pkgs/desktops/pantheon/desktop/elementary-session-settings/default.nix

maybe add a link where upstream has it defined?

davidak · 2021-12-02T01:47:19Z

This seem to work.

Tested:

booting several times
login
lock screen
suspend, resume
start applications
restart
shut down

davidak

The changes look good to me and work.

bobby285271 · 2021-12-02T02:58:19Z

I updated the PR description. I guess I should close this for now to avoid confusions, I don't plan to merge this for now. I will re-open this or reflect this changes in other PR when ready. I am keeping the branch for anyone who wants to test this.

davidak · 2021-12-03T03:09:12Z

I noticed today that i can't always click, for example moving windows or make a different window active by clicking on it don't always work, i have to click in different places. Also, hotkeys for screenshot does not work anymore. Screenshots using the app work. Keyboard keys for volume up, down and mute don't work anymore. In the browser file save dialog, i can't click "Save", a workaround is to click once in the Name field.

Nothing related in logs.

bobby285271 · 2021-12-07T15:31:13Z

I can reproduce the keyboard keys issue but not other yet, also night light no longer works for me. I guess it will be nice to report the issue upstream as I don't know how to deal with these downstream currently. Anyway I am tracking this in https://github.com/NixOS/nixpkgs/projects/21#card-73471036 so we can make sure we revisit this when doing Pantheon 7 update.

davidak · 2021-12-13T19:05:25Z

The described problems are actually not related to systemd session. They also occur with latest stable NixOS 21.11.334139.1bd4bbd49be.

bobby285271 · 2021-12-14T01:22:04Z

For me, at least the keyboard keys issue happens only with --builtin removed...
For your information the filechooser has been redesigned in Pantheon 6.0.4.

bobby285271 · 2023-05-22T14:19:27Z

Now also applied #233981 (comment).

gnome-session!93 will likely happen in GNOME 46.

This is now needed as gnome-session 46 drops `--builtin` option.

…on for Pantheon See Nixpkgs pull request 233981.

@bindir

This is changed after we manage session with systemd, as [email protected] has `ExecStart=@bindir@/gala`.

Otherwise it doesn't autostart after user session managed by systemd.

Which is manually added in the nixos module.

bobby285271 · 2024-03-29T02:46:40Z

elementary/session-settings#73 has been merged, I would like to land this soon

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 4, 2021

bobby285271 requested review from davidak and jtojnar October 4, 2021 02:19

ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 4, 2021

bobby285271 mentioned this pull request Oct 4, 2021

Fix gala-x11.service timeout elementary/gala#1265

Merged

bobby285271 force-pushed the pantheon-systemd branch from 6b12858 to c6c0457 Compare October 4, 2021 08:40

bobby285271 commented Oct 4, 2021

View reviewed changes

pkgs/desktops/pantheon/desktop/gala/default.nix Outdated Show resolved Hide resolved

bobby285271 mentioned this pull request Oct 4, 2021

fetchpatch: ignores file renames #32084

Open

bobby285271 added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Oct 21, 2021

bobby285271 force-pushed the pantheon-systemd branch from c6c0457 to e2b74ff Compare November 25, 2021 13:59

davidak reviewed Dec 2, 2021

View reviewed changes

nixos/modules/services/x11/desktop-managers/pantheon.nix Outdated

Copy link

Member

davidak Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to have both?

davidak reviewed Dec 2, 2021

View reviewed changes

pkgs/desktops/pantheon/desktop/elementary-session-settings/default.nix Outdated

Copy link

Member

davidak Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a link where upstream has it defined?

davidak mentioned this pull request Dec 2, 2021

Add systemd support elementary/session-settings#55

Merged

davidak approved these changes Dec 2, 2021

View reviewed changes

bobby285271 closed this Dec 2, 2021

bobby285271 reopened this Jan 7, 2022

bobby285271 force-pushed the pantheon-systemd branch from e2b74ff to 98aa62f Compare January 7, 2022 08:55

ofborg bot requested a review from davidak January 7, 2022 09:08

bobby285271 force-pushed the pantheon-systemd branch from e5b8bdc to 25276c0 Compare May 22, 2023 14:09

github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 22, 2023

bobby285271 force-pushed the pantheon-systemd branch 2 times, most recently from 1b06cb0 to 3e1539a Compare July 9, 2023 09:53

ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 9, 2023

bobby285271 added this to the 24.05 milestone Nov 4, 2023

bobby285271 force-pushed the pantheon-systemd branch from 3e1539a to 47578c3 Compare January 11, 2024 15:11

github-actions bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 11, 2024

This was referenced Jan 12, 2024

nixosTests.pantheon: Extend the test #280526

Merged

Missing gala-daemon systemd service elementary/gala#1826

Closed

bobby285271 force-pushed the pantheon-systemd branch from 47578c3 to 7fc4990 Compare January 14, 2024 09:48

bobby285271 force-pushed the pantheon-systemd branch from 7fc4990 to af4d6f9 Compare January 27, 2024 08:47

ofborg bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 27, 2024

bobby285271 force-pushed the pantheon-systemd branch from af4d6f9 to 3137d87 Compare February 14, 2024 05:53

bobby285271 added 5 commits March 17, 2024 13:41

pantheon: Manage user session with systemd

7522f97

This is now needed as gnome-session 46 drops `--builtin` option.

nixos/display-managers: Don't force graphical-session.target activati…

0b41a85

…on for Pantheon See Nixpkgs pull request 233981.

nixosTests.pantheon: Fix gala environ subtest

e49a58b

This is changed after we manage session with systemd, as [email protected] has `ExecStart=@bindir@/gala`.

nixos/pantheon: Add missing gala-daemon systemd services

a4bca9a

Otherwise it doesn't autostart after user session managed by systemd.

nixosTests.pantheon: Add test for [email protected]

bf2ba6e

Which is manually added in the nixos module.

bobby285271 force-pushed the pantheon-systemd branch from 3137d87 to bf2ba6e Compare March 17, 2024 05:45

bobby285271 mentioned this pull request Mar 19, 2024

GNOME: 45 → 46 #291339

Merged

27 tasks

bobby285271 removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Mar 29, 2024

bobby285271 marked this pull request as ready for review March 29, 2024 14:35

bobby285271 merged commit e96d5c1 into NixOS:master Mar 29, 2024

bobby285271 deleted the pantheon-systemd branch March 29, 2024 14:55

bobby285271 mentioned this pull request Apr 5, 2024

pantheon.gala: Fix missing URI handler #301847

Merged

13 tasks

Uh oh!

Conversation

bobby285271 commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

davidak commented Oct 4, 2021

Uh oh!

bobby285271 commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

davidak Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

davidak Dec 2, 2021

Choose a reason for hiding this comment

Uh oh!

davidak commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidak left a comment

Choose a reason for hiding this comment

Uh oh!

bobby285271 commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidak commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobby285271 commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidak commented Dec 13, 2021

Uh oh!

bobby285271 commented Dec 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobby285271 commented May 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobby285271 commented Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bobby285271 commented Oct 4, 2021 •

edited

Loading

bobby285271 commented Oct 4, 2021 •

edited

Loading

davidak commented Dec 2, 2021 •

edited

Loading

bobby285271 commented Dec 2, 2021 •

edited

Loading

davidak commented Dec 3, 2021 •

edited

Loading

bobby285271 commented Dec 7, 2021 •

edited

Loading

bobby285271 commented Dec 14, 2021 •

edited

Loading

bobby285271 commented May 22, 2023 •

edited

Loading

bobby285271 commented Mar 29, 2024 •

edited

Loading