Skip to content

[staging] boost: default to boost 1.77 and refactor#138309

Merged
peti merged 3 commits intoNixOS:stagingfrom
hjones2199:boostup
Nov 27, 2021
Merged

[staging] boost: default to boost 1.77 and refactor#138309
peti merged 3 commits intoNixOS:stagingfrom
hjones2199:boostup

Conversation

@hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Sep 17, 2021 •
edited
Loading

Motivation for this change

Most packages that depend on the boost libraries in nixpkgs are pointing at the unversioned "boost" package. Unversioned boost is currently 1.69.0, which was released in 2018. The default should be the newest boost library available (1.77). I expect build-time breakages, but it should be fairly straightforward to pin broken packages to an older boost revision once they are identified.

The level of divergence (particularly the addition of boost-build) since I submitted #120259, and the fact that I wanted to combine the addition of boost 1.77 into the same PR made it easier to start the request from scratch.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@hjones2199 hjones2199 marked this pull request as draft September 17, 2021 17:58
@hjones2199
Copy link
Member Author

hjones2199 commented Sep 17, 2021

Do to the addition of patches in boost-build, boost 1.77 currently fails in the patch phase. Solving that without breaking old versions of boost on darwin is needed.

@hjones2199
Copy link
Member Author

hjones2199 commented Oct 11, 2021

Replacing the darwin-specific patch with an equivelent substituteInPlace allows it to work across versions (including 1.77). Still probably a ton of broken packages that wont build without passing boost = boost16x but the PR is ready for review.

@hjones2199 hjones2199 marked this pull request as ready for review October 11, 2021 18:03
@hjones2199 hjones2199 mentioned this pull request Oct 11, 2021
Closed
10 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 11, 2021
@hjones2199 hjones2199 requested a review from peti October 11, 2021 18:50
@r-burns
Copy link
Contributor

r-burns commented Oct 12, 2021

uhd fails but is fixed by bumping to latest 4.1.0.3. I've tried a handful of packages and that's the failure I found so far

@zhaofengli zhaofengli mentioned this pull request Oct 15, 2021
Closed
@oxalica
Copy link
Contributor

oxalica commented Nov 27, 2021

What's blocking this issue now? Is it just uhd?

@peti peti merged commit 84f26a4 into NixOS:staging Nov 27, 2021
@oxalica oxalica mentioned this pull request Nov 29, 2021
Merged
12 tasks
@NickCao NickCao mentioned this pull request Dec 2, 2021
Merged
13 tasks
veprbl pushed a commit that referenced this pull request Dec 20, 2021
@vcunat
mapnik: use boost175
636ec22 
PR #138309 switched the default to 177 and that broke the build.
veprbl pushed a commit that referenced this pull request Dec 20, 2021
@vcunat
powerdns: use boost172
4bffea9 
PR #138309 switched the default to 177 and that broke the build.
veprbl pushed a commit that referenced this pull request Dec 20, 2021
@vcunat
librecad: use boost175
b6b6bc5 
PR #138309 switched the default to 177 and that broke the build.
@trofi
Copy link
Contributor

trofi commented Dec 22, 2021

arc_unpacker now fails it's own tests in staging-next. Bisected down to eca5088 boost: default to boost 1.77:

$ nix build -f. arc_unpacker -L
...
arc_unpacker-unstable> /build/source/tests/dec/cat_system/int_archive_decoder_test.cc:38
arc_unpacker-unstable> ...............................................................................
arc_unpacker-unstable> /build/source/tests/test_support/decoder_support.cc:35: FAILED:
arc_unpacker-unstable>   {Unknown expression after the reported line}
arc_unpacker-unstable> due to unexpected exception with message:
arc_unpacker-unstable>   Premature end of file

@veprbl
Copy link
Member

veprbl commented Dec 22, 2021

@trofi Right, that's #151469

@doronbehar doronbehar mentioned this pull request Dec 23, 2021
Merged
13 tasks
vcunat added a commit that referenced this pull request Dec 25, 2021
@vcunat
ycmd: use boost174
597743c 
PR #138309 switched the default to 177 and that broke the build.
/cc #151469.
@hjones2199 hjones2199 mentioned this pull request Dec 26, 2021
Merged
12 tasks
@FliegendeWurst FliegendeWurst mentioned this pull request Jan 29, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peti peti Awaiting requested review from peti

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hjones2199 @r-burns @oxalica @trofi @veprbl @peti