Skip to content

terraform: 1.0.6 -> 1.0.7#138088

Merged
amaxine merged 1 commit intoNixOS:masterfrom
marsam:update-terraform
Sep 16, 2021
Merged

terraform: 1.0.6 -> 1.0.7#138088
amaxine merged 1 commit intoNixOS:masterfrom
marsam:update-terraform

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Sep 16, 2021

Motivation for this change

https://github.com/hashicorp/terraform/releases/tag/v1.0.7

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 16, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 16, 2021 •
edited
Loading

Result of nixpkgs-review pr 138088 at 8c909dd run on aarch64-linux 1

3 packages built successfully:
  • infracost
  • terraform (terraform_1_0)
  • terraform-full
6 suggestions:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:164:7:

        |
164 |       ./provider-path.patch
    |       ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:165:7:

        |
165 |       (fetchpatch {
    |       ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:185:17:

        |
185 |     patches = [ ./provider-path.patch ];
    |                 ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:193:17:

        |
193 |     patches = [ ./provider-path-0_15.patch ];
    |                 ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:177:17:

        |
177 |     patches = [ ./provider-path.patch ];
    |                 ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:201:17:

        |
201 |     patches = [ ./provider-path-0_15.patch ];
    |                 ^

Result of nixpkgs-review pr 138088 at 8c909dd run on x86_64-linux 1

4 packages built successfully:
  • infracost
  • terraform (terraform_1_0)
  • terraform-full
  • terraform_plugins_test
6 suggestions:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:193:17:

        |
193 |     patches = [ ./provider-path-0_15.patch ];
    |                 ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:201:17:

        |
201 |     patches = [ ./provider-path-0_15.patch ];
    |                 ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:164:7:

        |
164 |       ./provider-path.patch
    |       ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:165:7:

        |
165 |       (fetchpatch {
    |       ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:177:17:

        |
177 |     patches = [ ./provider-path.patch ];
    |                 ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/applications/networking/cluster/terraform/default.nix:185:17:

        |
185 |     patches = [ ./provider-path.patch ];
    |                 ^

@amaxine amaxine merged commit bbd6421 into NixOS:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@babariviere babariviere Awaiting requested review from babariviere

@timstott timstott Awaiting requested review from timstott

@zimbatm zimbatm Awaiting requested review from zimbatm

@Chili-Man Chili-Man Awaiting requested review from Chili-Man

@kalbasit kalbasit Awaiting requested review from kalbasit

1 more reviewer

@amaxine amaxine amaxine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marsam @r-rmcgibbo @amaxine