Conversation
alyssais
added
the
6.topic: cross-compilation
ofborg
bot
added
10.rebuild-darwin: 501+
There was a problem hiding this comment.
Might be nicer to move this closer the other build customization flags. After makeFlags I would say, but we have not settled on a location yet: https://discourse.nixos.org/t/document-attribute-ordering-in-package-expressions/4887, https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-ordering.md
There was a problem hiding this comment.
I think it makes sense to have it just before the build inputs, because it changes how they work (somewhat), so it's important to have seen that just before seeing the build inputs.
There was a problem hiding this comment.
I guess this is for gdk-pixbuf-query-loaders?
Mindavi
left a comment
Mindavi
left a comment
There was a problem hiding this comment.
Great to see someone working on this. I've had a patch in a local tree for some time, but I wasn't sure if it's a good idea to just not create the loader cache. I guess we'll see where this goes. At least it builds now, which is already better than nothing.
There was a problem hiding this comment.
LGTM, except for one comment I left.
Note that I'm building this currently, but I have some other packages in the queue so it might take a while.
Fixing the comment I described fixes the build, but otherwise it fails (because the cache file can't be found).
gobject-introspection doesn't cross build at the moment, and doesn't work well with cross even when it does, so this is far more likely to keep working if we just disable it when cross compiling.
4 participants
Motivation for this change
gobject-introspection doesn't cross build at the moment, and doesn't
work well with cross even when it does, so this is far more likely to
keep working if we just disable it when cross compiling.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)