Skip to content

datadog-agent: 6.11.2 -> 7.30.2#136109

Merged
SuperSandro2000 merged 8 commits intoNixOS:masterfrom
john-consumable:master
Sep 12, 2021
Merged

datadog-agent: 6.11.2 -> 7.30.2#136109
SuperSandro2000 merged 8 commits intoNixOS:masterfrom
john-consumable:master

Conversation

@john-consumable
Copy link
Contributor

@john-consumable john-consumable commented Aug 29, 2021

Motivation for this change

#105221 and #101964

Plus, datadog-agent failed to build on master (for me).

Things done

datadog-agent is now built as a go module. However, the build process
is now to be driven by the python invoke tool. While datadog-agent
builds with buildGoModule, some investigation should be done to ensure
we are not missing any integrations or features from the invoke build
system.

This also updates datadog-agent from python 2.7 to 3.x.

One other issue of note: most of the invoke tasks seem to use some git parsing to get version numbers and the like. This package may need to be checked for reproducibility issues now.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin (unsupported platform)
    • aarch64-darwin (unsupported platform)
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant (service changes documented)
    • (Module addition) Added a release notes entry if adding a new NixOS module (no additional NixOS module)
  • Fits CONTRIBUTING.md.

@john-consumable john-consumable force-pushed the master branch 2 times, most recently from fa76106 to 75ab976 Compare August 29, 2021 18:22
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 29, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 29, 2021
@r-rmcgibbo

This comment has been minimized.

@john-consumable
Copy link
Contributor Author

Looks like I don't understand the integrations very well. Any help would be appreciated to help CI.

@ofborg ofborg bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 7, 2021
datadog-agent is now built as a go module.  However, the build process
is now to be driven by the python invoke tool.  While datadog-agent
builds with buildGoModule, some investigation should be done to ensure
we are not missing any integrations or features from the invoke build
system.

This also updates datadog-agent from python 2.7 to 3.x.

One other issue of note: most of the invoke tasks seem to use some git
parsing to get version numbers and the like. This package may need to
be checked for reproducibility issues now.
@john-consumable john-consumable force-pushed the master branch 2 times, most recently from 143762f to e22336c Compare September 8, 2021 08:16
@john-consumable
Copy link
Contributor Author

@ofborg build datadog-agent datadog-process-agent

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 8, 2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "7.30.1";
rev = version;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done.

@SuperSandro2000 SuperSandro2000 merged commit a79648d into NixOS:master Sep 12, 2021
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants