Conversation
Updates Mailpile to the most recent GitHub release. Added fasteners-python2 to python2-packages. The current `fasteners` python package in pulls in a dependency on Django which is incompatible with python2. So I needed to downgrade the `fasteners` to a version which does not have Django as a dependency.
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
Co-authored-by: Gytis Ivaskevicius <[email protected]>
| @@ -22,18 +23,27 @@ python2Packages.buildPythonApplication rec { | |||
| appdirs | |||
There was a problem hiding this comment.
Can we use python3 instead?
There was a problem hiding this comment.
No, Mailpile does not support Python 3 (they are planning it since 2013). This "updated" version is from 2019 (last release on GitHub) so there is also no Python 3 support.
There was a problem hiding this comment.
I found a similar pull request updating Mailpile (#97274). However, the last pull request does not work anymore because of the fasteners library. So when this is merged, the old PR can be closed.
Also it seems like you already asked whether Python 3 support is possible one year ago :D
There was a problem hiding this comment.
Python2 should be removed from as much as possible because we no longer maintain it and don't even check for breakages when updating libraries.
3 participants
Motivation for this change
Have the most recent version of Mailpile in nixpkgs.
Things done
Mailpile package has been upgraded to the 1.0.0rc6 version (most recent on their GitHub). Because the
fastenerslibrary dropped support for python 2 an older version of it had to be used to compile Mailpile.sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)