runCommandNoCC: fix ofborg status#134230
Merged
roberth merged 1 commit intoNixOS:masterfrom Aug 15, 2021
Merged
Conversation
The original pr was merged a bit too soon. Removing the deprecation warning shouldn't be necessary, but for now, we need to prioritize making ofborg green.
Member
Author
|
It doesn't like that the status quo "does not evaluate cleanly" so I'll merge this without proper confirmation. This is a known issue with ofborg. |
This was referenced Aug 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original pr was merged a bit too soon.
Removing the deprecation warning shouldn't be necessary, but for
now, we need to prioritize making ofborg green.
A proper fix consists of something like d6aafb3 but in ofborg's code.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)