runCommandNoCC -> runCommand deprecation#134225
Merged
siraben merged 8 commits intoNixOS:masterfrom Aug 15, 2021
Merged
Conversation
roberth
requested review from
FRidh,
adisbladis,
andir,
danieldk,
edolstra,
infinisil,
jonringer,
nbp and
zowoq
as code owners
github-actions
bot
added
6.topic: agda
roberth
force-pushed
the
runCommand-no-nocc
branch
from
a21485b to
f5c1f79
Compare
andir
reviewed
Aug 15, 2021
Member
There was a problem hiding this comment.
Do we plan removal at some point in the future? Now would be the time to announce that we will drop in in ~2022.11?
Member
Author
There was a problem hiding this comment.
I'd say it announces itself. No need to use up more brain bandwidth than necessary.
Member
There was a problem hiding this comment.
Though, maybe link to the PR like we did for deprecating stdenv.lib. Not necessary though.
roberth
force-pushed
the
runCommand-no-nocc
branch
from
f5c1f79 to
c9ec4b2
Compare
This has been synonymous for ~5y.
This has been synonymous for ~5y.
This has been synonymous for ~5y. Note that many of these runCommand bindings are unused, but that's ok for generated code.
It has always been a synonym.
It has been synonymous with runCommand ~5y.
roberth
force-pushed
the
runCommand-no-nocc
branch
from
c9ec4b2 to
9feb144
Compare
This allows the aliases file to produce deprecation warnings without triggering the check against warnings. This allows for a better user experience when deprecations occur. Moreover, Nixpkgs itself shouldn't rely on its backcompat aliases.
Member
|
Result of 1 package built:
|
Member
Author
|
Oh no, I was still looking into making ofborg accept this. |
Member
Author
|
I'll make a PR to fix ofborg eval. |
11 tasks
Member
Author
|
The deprecation warning has been reverted in #134230, making this PR ineffective. We can't have deprecate it until NixOS/ofborg#575, unless someone knows a workaround to please / trick ofborg. |
13 tasks
andersk
added a commit
to andersk/nixpkgs-mozilla
that referenced
this pull request
Sep 26, 2022
It has been synonymous with runCommand since NixOS/nixpkgs@97bfc2f (2016-09-26), was deprecated in NixOS/nixpkgs#134225 (2021-08-15), and was removed in NixOS/nixpkgs#192681 (2022-09-24). Signed-off-by: Anders Kaseorg <[email protected]>
nbp
pushed a commit
to mozilla/nixpkgs-mozilla
that referenced
this pull request
Oct 3, 2022
It has been synonymous with runCommand since NixOS/nixpkgs@97bfc2f (2016-09-26), was deprecated in NixOS/nixpkgs#134225 (2021-08-15), and was removed in NixOS/nixpkgs#192681 (2022-09-24). Signed-off-by: Anders Kaseorg <[email protected]>
mightyiam
added a commit
to mightyiam/nix-unit
that referenced
this pull request
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Simplify to remove doubt when writing and reviewing expressions.
This produces no rebuilds except in the yarn2nix-moretea package, which is updated to use
runCommand.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)