Skip to content

llvmPackages_13: Forward port the patches from llvmPackages_12#133168

Merged
primeos merged 5 commits intoNixOS:masterfrom
primeos:llvmPackages_13
Aug 9, 2021
Merged

llvmPackages_13: Forward port the patches from llvmPackages_12#133168
primeos merged 5 commits intoNixOS:masterfrom
primeos:llvmPackages_13

Conversation

@primeos
Copy link
Member

@primeos primeos commented Aug 8, 2021

Motivation for this change

#133148 and #132643.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@primeos primeos requested a review from matthewbauer as a code owner August 8, 2021 17:20
@primeos
Copy link
Member Author

primeos commented Aug 8, 2021

@ofborg build llvmPackages_13

@ofborg ofborg bot requested review from 7c6f434c, dtzWill and lovek323 August 8, 2021 17:32
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 8, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 8, 2021

Result of nixpkgs-review pr 133168 at c8db49f run on x86_64-linux 1

13 packages skipped due to time constraints:
  • lldb_13 (llvmPackages_13.lldb)
  • llvmPackages_13.clang (llvmPackages_13.libstdcxxClang)
  • llvmPackages_13.libclang (llvmPackages_13.clang-unwrapped)
  • llvmPackages_13.clangNoCompilerRt
  • llvmPackages_13.clangNoCompilerRtWithLibc
  • llvmPackages_13.clangNoLibc
  • llvmPackages_13.clangNoLibcxx
  • llvmPackages_13.clangUseLLVM
  • llvmPackages_13.libcxxClang
  • llvmPackages_13.libcxxStdenv
  • ...
2 packages built successfully:
  • llvmPackages_13.clang-manpages
  • llvmPackages_13.compiler-rt (llvmPackages_13.compiler-rt-libc ,llvmPackages_13.compiler-rt-no-libc)
6 suggestions:
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/compilers/llvm/13/lldb/default.nix:40:5:

       |
40 |     ./gnu-install-dirs.patch
   |     ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/compilers/llvm/13/clang/default.nix:37:7:

       |
37 |       ./purity.patch
   |       ^
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/compilers/llvm/13/clang/default.nix:108:5:

        |
108 |     installPhase = ''
    |     ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/compilers/llvm/13/lldb/default.nix:35:5:

       |
35 |     (runCommand "resource-dir.patch" {
   |     ^
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/compilers/llvm/13/clang/default.nix:104:5:

        |
104 |     buildPhase = ''
    |     ^
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/compilers/llvm/13/lldb/default.nix:34:5:

       |
34 |     ./procfs.patch
   |     ^

@risicle
Copy link
Contributor

risicle commented Aug 8, 2021

Darwin still seems pretty broken (tested macos 10.15), but nixpkgs-review was happy for me on nixos x86_64.

@primeos
Copy link
Member Author

primeos commented Aug 9, 2021

Yeah, we lack Darwin maintainers.

@primeos primeos merged commit 850e3da into NixOS:master Aug 9, 2021
@yu-re-ka yu-re-ka mentioned this pull request Aug 26, 2021
Merged
11 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@lovek323 lovek323 Awaiting requested review from lovek323

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@primeos @r-rmcgibbo @risicle @rrbutani