Skip to content

buildPythonApplication: use new function for Python applications#13124

Merged
FRidh merged 1 commit intoNixOS:masterfrom
FRidh:buildPythonApplication
Feb 23, 2016
Merged

buildPythonApplication: use new function for Python applications#13124
FRidh merged 1 commit intoNixOS:masterfrom
FRidh:buildPythonApplication

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 19, 2016

In 49c6893 buildPythonApplication was introduced.
This commit converts (almost) all occurrences of buildPythonPackage with buildPythonApplication except those in

  • pkgs/top-level/python-packages.nix
  • pkgs/development/python-modules/

@FRidh FRidh added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 19, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @aszlig, @roblabla and @bosu to be potential reviewers

@FRidh
Copy link
Member Author

FRidh commented Feb 19, 2016

cc @domenkozar

@FRidh FRidh force-pushed the buildPythonApplication branch from e598e78 to 4d06bf7 Compare February 19, 2016 12:17
@FRidh FRidh changed the title buildPythonPackage -> buildPythonApplication buildPythonApplication: use new function for Python applications Feb 19, 2016
@dezgeg
Copy link
Contributor

dezgeg commented Feb 19, 2016

I guess the namePrefix = "" should be removed at the same time?

@FRidh FRidh closed this Feb 19, 2016
@FRidh
Copy link
Member Author

FRidh commented Feb 19, 2016

@dezgeg Good point. But that seems a bit harder to automate though.

@FRidh FRidh reopened this Feb 19, 2016
@dezgeg
Copy link
Contributor

dezgeg commented Feb 19, 2016

Maybe something like (untested):

for f in $(git diff --name-only); do
    sed -e '/namePrefix *=/d' -i $f
done

@FRidh
Copy link
Member Author

FRidh commented Feb 21, 2016

Will need to add buildPythonApplication to docs.

@FRidh FRidh added this to the 16.03 milestone Feb 21, 2016
@FRidh
Copy link
Member Author

FRidh commented Feb 23, 2016

Having namePrefix=""; inside buildPythonApplication is no problem. They can be removed later.

FRidh added a commit that referenced this pull request Feb 23, 2016
buildPythonApplication: use new function for Python applications
@FRidh FRidh merged commit 40ca841 into NixOS:master Feb 23, 2016
@FRidh FRidh deleted the buildPythonApplication branch February 23, 2016 15:02
@jgillich jgillich mentioned this pull request Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants