[RFC] hostbridge and IPv6 for containers#12736
Closed
kampfschlaefer wants to merge 12 commits intoNixOS:release-15.09from
Closed
[RFC] hostbridge and IPv6 for containers#12736kampfschlaefer wants to merge 12 commits intoNixOS:release-15.09from
kampfschlaefer wants to merge 12 commits intoNixOS:release-15.09from
Conversation
hostBridge now takes precedence over hostAddress and hostAddress6.
When the ping was executed, the container might not have finished starting. Or the host-side of the container wasn't finished with config. Waiting for 2 seconds in between fixes this.
Mostly copied from containers.nix but I stripped away the imperative container tests.
Seems odd to define the container IPs with their prefix length attached. There should be a better way…
fpletz
added
the
6.topic: nixos
Member
No need for own ip-calls when the container-solution already has that.
Member
|
Finally got some time to review your changes. Big 👍, very cool! Could you maybe group your commits into 2 or 3 commits without the fixes? |
Contributor
Author
Will do. Also there is one little detail missing: when host-bridge is used, the vb-* device needs to be deleted to make sure. Got bitten by this unclean exit several times now… How do I go then with this PR? Surely it shouldn't be merged into 15.09 anymore. But is it for master or can it also go into 16.x? |
Contributor
Author
|
superseeded by #14018 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
scratching my own itch I had some ideas on how to a) give nixos containers IPv6 and b) allow declarative containers to join an existing bridge for connectivity.
What I mostly do not like yet: It should be possible to define the network-settings inside the container with
networking.interfaces.eth0.*instead of defining it from the outside.So please comment on this, maybe I can rework this into something usable to get IPv6 and bridging to declarative containers.