pkgs/top-level/release.nix: include ocamlPackages in nixpkgs:trunk again#126934
Closed
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
Closed
pkgs/top-level/release.nix: include ocamlPackages in nixpkgs:trunk again#126934sternenseemann wants to merge 1 commit intoNixOS:masterfrom
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
Conversation
ocamlPackages has been removed in the past due to build capacity shortage, this situation is not today's anymore, so we can remove this “temporary” workaround. The stress caused by this shouldn't be too bad — the whole ocamlPackages set builds under one hour on normal hardware. I'll leave it to the respective ecosystem's maintainers or other concerned parties to re-add the remaining package sets like perlPackages or rPackages.
ofborg
bot
added
8.has: package (new)
|
Result of 1 package marked as broken and skipped:
2 packages failed to build:198 packages skipped due to time constraints:
395 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 2 packages failed to build:204 packages skipped due to time constraints:
416 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
Member
How so we do not have a build capacity shortage anymore? Did our capacity increase? Did we start building other things less? Related #115246. |
Member
Author
I'm not familiar with the situation when this was introduced in 2016, but I can't imagine it is still the same. I think it should be fine to build the
I'll go ahead and close this PR, it is quite hacky and I do agree it has an unnecessarily high impact: Since it recursed into all ocaml package set, it would have added 14 additional ocaml package sets. This PR only adds the default one, so only adds 1/14 of the builds. |
This was referenced Jul 24, 2021
Contributor
|
Off topic for this pull request specifically but since rPackages was mentioned, I'd be keen on building rPackages as part of trunk if there's capacity. The rPackages are built by hydra currently as part of the r-updates jobset, but that job is currently pointed at @peti's r-updates branch. I've requested pointing this at my branch instead (#138210), but if it was part of trunk that'd be significantly better. Note though that there are currently ~22k R packages. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
FliegendeWurst
approved these changes
Dec 1, 2024
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
wegank
added
the
2.status: merge conflict
13 tasks
13 tasks
Contributor
|
This was handled by #406555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ocamlPackages has been removed in the past due to build capacity
shortage, this situation is not today's anymore, so we can remove this
“temporary” workaround.
The stress caused by this shouldn't be too bad — the whole ocamlPackages
set builds under one hour on normal hardware.
I'll leave it to the respective ecosystem's maintainers or other
concerned parties to re-add the remaining package sets like perlPackages
or rPackages.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)