openssl: fix Darwin cross infinite recursion#126844
Merged
domenkozar merged 1 commit intoNixOS:masterfrom Jun 14, 2021
Merged
Conversation
stdenv depends on openssl, and isGNU depends on stdenv. Thanks-to: sternenseemann <[email protected]> Fixes: NixOS#126829
alyssais
added
the
6.topic: cross-compilation
Member
Author
|
@ofborg build pkgsCross.aarch64-darwin.nix |
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Eval looks good: $ nix-instantiate -A pkgsCross.aarch64-darwin.hello --argstr system x86_64-darwin
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/r5zq68sqm7qbwkfq9yflwwq00pg5qgwd-hello-aarch64-apple-darwin-2.10.drvBut this will fail when not using darwin as the build platform as well, so it is a fragile fix in any case (not sure if we need to care about this cross compilation direction?). $ nix-instantiate -A pkgsCross.aarch64-darwin.hello --argstr system x86_64-linux
error: infinite recursion encountered, at undefined position
(use '--show-trace' to show detailed location information) |
Member
|
For reference this is the full trace: |
domenkozar
approved these changes
Jun 14, 2021
Member
|
Nix still doesn't build but that's out of scope for this fix. Thanks! |
Contributor
|
Successfully created backport PR #126852 for |
Member
|
For the record, I think we need to solve this differently. I fear that this workaround which only tackles one specific case may not be enough in the long run. I'll try to have a look at the new trace tomorrow and see if I can come up with anything. I think at the very least we should keep #126829 (with a modified title) open for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdenv depends on openssl, and isGNU depends on stdenv.
Motivation for this change
Fixes #126829.
Thanks to @sternenseemann for figuring out what was going on here.
Haven't tested myself because I don't have Darwin.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)