backport action: run only when the label starts with 'backport'#126825
Merged
domenkozar merged 1 commit intoNixOS:masterfrom Jun 19, 2021
Merged
backport action: run only when the label starts with 'backport'#126825domenkozar merged 1 commit intoNixOS:masterfrom
domenkozar merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: policy discussion
ofborg
bot
added
10.rebuild-darwin: 0
blaggacao
suggested changes
Jun 14, 2021
Contributor
There was a problem hiding this comment.
The zeebe docs suggest that the label selector should be done differently.
# Optional
# Regex pattern to match github labels
# Must contain a capture group for target branchname
# label_pattern: ^backport
dotlambda
reviewed
Jun 14, 2021
Member
Author
That's orthogonal, it allows us to define what label is interpreted as valid backport label. The linked issue will still reproduce. |
Ma27
approved these changes
Jun 19, 2021
Contributor
|
Seems this label condition stopped working at some point, now it is running for every merged PR. e.g. #182370 @winterqt You may be interested in taking a look at it? |
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
May 4, 2025
The backport job was previously triggered on any label activity, i.e. when the backport label was already set and a new label added, the backport would have been triggered again. That's because github.event_name is actually "pull_request_target" in this case, not "closed" or "labeled" (the event's types). Thus, this part of the condition was always true. This also means that the second part, the startsWith, was never evaluated. It had its arguments flipped and would have always been false. This was introduced in NixOS#126825, but has never really worked as intended. Resolves NixOS#199556
1 task
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
May 4, 2025
The backport job was previously triggered on any label activity, i.e. when the backport label was already set and a new label added, the backport would have been triggered again. That's because github.event_name is actually "pull_request_target" in this case, not "closed" or "labeled" (the event's types). Thus, this part of the condition was always true. This also means that the second part, the startsWith, was never evaluated. It had its arguments flipped and would have always been false. This was introduced in NixOS#126825, but has never really worked as intended. Resolves NixOS#199556 (cherry picked from commit b62d9a2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tested this, but it looks like it should work.