Skip to content

Comments

iosevka: 5.0.2 -> 7.0.4, iosevka-bin: 5.0.5 -> 7.0.4 #126664

Merged
kevincox merged 2 commits intoNixOS:masterfrom
figgyc:update-iosevka
Jun 13, 2021
Merged

iosevka: 5.0.2 -> 7.0.4, iosevka-bin: 5.0.5 -> 7.0.4 #126664
kevincox merged 2 commits intoNixOS:masterfrom
figgyc:update-iosevka

Conversation

@figgyc
Copy link
Contributor

@figgyc figgyc commented Jun 12, 2021

Motivation for this change

There has been a few new glyphs added to Iosevka since this package was last updated, I noticed as I was trying to compile a custom version and it didn't work with the current package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 12, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from kevincox June 12, 2021 12:35
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 12, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jun 12, 2021

@figgyc please resolve the merge conflict.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 12, 2021
@ofborg ofborg bot requested review from cstrahan and midchildan June 12, 2021 17:30
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 12, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 12, 2021

Result of nixpkgs-review pr 126664 at 410b187 run on aarch64-linux 1

1 package failed to build:
3 packages skipped due to time constraints:
  • iosevka
  • iosevka-bin
  • lumo
7 packages built successfully:
  • bat-extras.prettybat
  • discourse
  • nixos-install-tools
  • parity-ui
  • teleprompter
  • vscode-extensions.matklad.rust-analyzer
  • zerobin

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 12, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jun 12, 2021

sorry for the new merge conflict. Please hit someone up on matrix when you resolved it that we can merge this asap.

@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 12, 2021
@figgyc
Copy link
Contributor Author

figgyc commented Jun 13, 2021

@SuperSandro2000 I've resolved the merge conflict, can you (or someone else) take another look? I did ask on matrix before I went to bed last night but seems like nobody did.

@kevincox kevincox merged commit b1f74dd into NixOS:master Jun 13, 2021
This was referenced Jun 29, 2021
Closed
Closed
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevincox kevincox kevincox approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

@midchildan midchildan Awaiting requested review from midchildan

+1 more reviewer

@moni-dz moni-dz moni-dz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@figgyc @SuperSandro2000 @r-rmcgibbo @kevincox @moni-dz @Janik-Haag