nyxt: fix darwin build by midchildan · Pull Request #126082 · NixOS/nixpkgs

midchildan · 2021-06-07T15:07:43Z

Motivation for this change

Continuation of #125113.

Fix the Darwin build
Use the GI-GTK backend as recommended by @jmercouris
Ran nixpkgs-fmt

Keyboard input is still not working, but it turned out to be an issue with WebKitGTK so I'm preparing a separate issue for it. Currently, all packages using WebKitGTK would have the same issue on Darwin.

ping @mjlbach

Things done

midchildan · 2021-06-07T15:10:12Z

pkgs/applications/networking/browsers/nyxt/default.nix

Setting GST_PLUGIN_SYSTEM_PATH_1_0 is handled by wrapGApps. It suffices to put these in buildInputs.

midchildan · 2021-06-07T15:12:19Z

pkgs/applications/networking/browsers/nyxt/default.nix

xclip in buildInputs doesn't have any effect because it's a CLI tool, not a library. I've added xclip to the wrapper instead.

notify-osd is removed since it's no longer needed. Details in #125113 (comment).

midchildan · 2021-06-07T15:16:33Z

pkgs/applications/networking/browsers/nyxt/default.nix

This didn't work because gappsWrapperArgs is computed at preFixup, which happens after installPhase.

midchildan · 2021-06-07T15:21:12Z

pkgs/development/lisp-modules/lisp-packages.nix

This was redundant because it creates a broken build artifact $out/bin/nyxt which promptly gets rebuilt by the subsequent commands.

midchildan · 2021-06-07T15:22:03Z

pkgs/development/lisp-modules/lisp-packages.nix

Replaces the GTK backend with the GI-GTK one.

midchildan · 2021-06-07T15:25:09Z

pkgs/development/lisp-modules/lisp-packages.nix

It's necessary to clear unnecessary environment variables because otherwise it hits the length limit imposed by the OS. This is similar to what is done in lisp-modules/define-package.nix:

nixpkgs/pkgs/development/lisp-modules/define-package.nix

Lines 89 to 99 in 8284fc3

env -i \

NIX_LISP="$NIX_LISP" \

NIX_LISP_PRELAUNCH_HOOK='nix_lisp_run_single_form "(progn

${lib.concatMapStrings (system: ''

(asdf:compile-system :${system})

(asdf:load-system :${system})

(asdf:operate (quote asdf::compile-bundle-op) :${system})

(ignore-errors (asdf:operate (quote asdf::deploy-asd-op) :${system}))

'') buildSystems}

)"' \

"$out/bin/${args.baseName}-lisp-launcher.sh"

r-rmcgibbo · 2021-06-07T15:25:57Z

Result of nixpkgs-review pr 126082 at 0498cf00 run on x86_64-linux 1

1 package failed to build:

nyxt

1 package built successfully:

lispPackages.nyxt

2 suggestions:

warning: missing-phase-hooks
checkPhase should probably contain runHook preCheck and runHook postCheck.

Near pkgs/applications/networking/browsers/nyxt/default.nix:82:3:
```
   |
82 |   checkPhase = ''
   |   ^
```
warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/applications/networking/browsers/nyxt/default.nix:51:3:
```
   |
51 |   installPhase =
   |   ^
```

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 126082 at 0498cf00 run on aarch64-linux 1

1 package failed to build:

nyxt

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

midchildan · 2021-06-07T16:13:28Z

I've pushed a few more fixes that does the following:

Add dontStrip = true to nyxt to fix the Linux build. Stripping results in a crash, likely because the resulting binary is already stripped once in lispPackages.nyxt.
Actually run the checkPhase, and make it installCheckPhase because it needs to run after installPhase. I've also disabled it for Darwin because the test would initialize the GTK runtime, which I suspect would fail on Hydra.
Add runHook as suggested by @r-rmcgibbo

babariviere · 2021-06-07T16:23:47Z

Result of nixpkgs-review pr 126082 run on x86_64-darwin 1

2 packages built:

lispPackages.nyxt
nyxt

mjlbach · 2021-06-07T16:28:43Z

The changes look good to me:

As noted, keyboard input event don't work unless holding down cmd, which may be a webkitgtk issue
It's a bit crash-ey for me, I can't use it more than 5 minutes without a crash, but that's probably an upstream issue
It's still quite laggy

Co-authored-by: Michael Lingelbach <[email protected]>

midchildan · 2021-06-07T18:52:51Z

I've now renamed lispPackages.nyxt to lispPackages.nyxt-unwrapped for more clarity and updated the release notes accordingly. This should have minimal effect because most users would have nyxt installed instead.

Also rebased to fix the merge conflict in the release notes.

nixos/doc/manual/from_md/release-notes/rl-2111.section.xml

ethancedwards8 · 2021-06-20T00:50:01Z

Result of nixpkgs-review pr 126082 run on x86_64-darwin 1

1 package built:

nyxt

stale · 2022-01-08T23:07:07Z

I marked this as stale due to inactivity. → More info

ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 7, 2021

midchildan mentioned this pull request Jun 7, 2021

[WIP] nyxt: fix on darwin #125113

Closed

9 tasks

ofborg bot requested a review from nlewo June 7, 2021 15:19

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 7, 2021

midchildan commented Jun 7, 2021

View reviewed changes

midchildan force-pushed the fix/nyxt-darwin branch 2 times, most recently from d2a2089 to 45f126d Compare June 7, 2021 16:07

midchildan mentioned this pull request Jun 7, 2021

[WIP] webkitgtk: Fix Darwin issues #126101

Draft

11 tasks

midchildan requested a review from ryantm as a code owner June 7, 2021 18:46

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Jun 7, 2021

nyxt: fix darwin build

922bd3b

Co-authored-by: Michael Lingelbach <[email protected]>

midchildan force-pushed the fix/nyxt-darwin branch from ff5c3a0 to a7556aa Compare June 7, 2021 18:49

ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Jun 7, 2021

SuperSandro2000 reviewed Jun 8, 2021

View reviewed changes

nixos/doc/manual/from_md/release-notes/rl-2111.section.xml Outdated Show resolved Hide resolved

Ambrevar mentioned this pull request Jun 10, 2021

The method and generic function differ in whether they accept &REST or &KEY arguments for NYXT:FFI-WINDOW-SET-BUFFER atlas-engineer/nyxt#1441

Closed

lispPackages.nyxt-unwrapped: rename from lispPackages.nyxt

c6598c6

midchildan force-pushed the fix/nyxt-darwin branch from a7556aa to c6598c6 Compare June 13, 2021 15:55

github-actions bot removed 8.has: changelog This PR adds or changes release notes 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation labels Jun 13, 2021

incidentist mentioned this pull request Jun 14, 2021

Support macOS atlas-engineer/nyxt#577

Open

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 8, 2022

veprbl mentioned this pull request Feb 4, 2022

Nyxt browser fails to build on aarch64-darwin, Package ‘notify-osd-0.9.34’ is unsupported on aarch64-darwin #150460

Open

wegank marked this pull request as draft February 2, 2023 09:01

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 2, 2023

wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024

	env -i \
	NIX_LISP="$NIX_LISP" \
	NIX_LISP_PRELAUNCH_HOOK='nix_lisp_run_single_form "(progn
	${lib.concatMapStrings (system: ''
	(asdf:compile-system :${system})
	(asdf:load-system :${system})
	(asdf:operate (quote asdf::compile-bundle-op) :${system})
	(ignore-errors (asdf:operate (quote asdf::deploy-asd-op) :${system}))
	'') buildSystems}
	)"' \
	"$out/bin/${args.baseName}-lisp-launcher.sh"

Uh oh!

Conversation

midchildan commented Jun 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

midchildan Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

midchildan Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

midchildan Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

midchildan Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

midchildan Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

midchildan Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

midchildan Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

r-rmcgibbo commented Jun 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

midchildan commented Jun 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babariviere commented Jun 7, 2021

Uh oh!

mjlbach commented Jun 7, 2021

Uh oh!

midchildan commented Jun 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ethancedwards8 commented Jun 20, 2021

Uh oh!

stale bot commented Jan 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

midchildan commented Jun 7, 2021 •

edited

Loading

r-rmcgibbo commented Jun 7, 2021 •

edited

Loading

midchildan commented Jun 7, 2021 •

edited

Loading

midchildan commented Jun 7, 2021 •

edited

Loading