Merged
Conversation
The test suite leads to nothing but tears, sorrow, and wasted build time. It probably should be disabled for all of them but doing only 9 (llvmPackages) and 11 (llvmPackages_latest, Rust) for now. Some of the failures have been fixed in LLVM main: - https://reviews.llvm.org/D97490 - https://reviews.llvm.org/D91043
zhaofengli
requested review from
LnL7,
Mic92,
matthewbauer and
zowoq
as code owners
github-actions
bot
added
the
6.topic: rust
ofborg
bot
added
10.rebuild-darwin: 0
9 tasks
Closed
11 tasks
zhaofengli
added a commit
to zhaofengli/nixpkgs
that referenced
this pull request
Jan 5, 2022
Same rationale in NixOS#125132.
zhaofengli
added a commit
to zhaofengli/nixpkgs
that referenced
this pull request
Jan 9, 2023
Same rationale in NixOS#125132.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bootstraps Rust native compilation on riscv64. The LLVM test suite needs to be disabled on RISC-V due to several failing tests (see commit message).
This depends on #115406 to actually work but can probably be merged now as it doesn't affect other platforms. Tested by building
rustcandcargoon native riscv64.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)