Skip to content

audit: Fix python bindings#123342

Merged
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
roblabla:audit-fix-python
Feb 7, 2022
Merged

audit: Fix python bindings#123342
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
roblabla:audit-fix-python

Conversation

@roblabla
Copy link
Contributor

@roblabla roblabla commented May 17, 2021 •
edited
Loading

Motivation for this change

Fixes the python bindings for libaudit, which currently don't build to a missing dependency on swig, and a hardcoded path in upstream source to /usr/include/linux/audit.h.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 17, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 17, 2021 •
edited
Loading

Result of nixpkgs-review pr 123342 at ce801ab7 run on aarch64-linux 1

891 packages marked as broken and skipped:
  • OVMF-CSM
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • agdaPackages.iowa-stdlib
  • aldor
  • ams-lv2
  • amuleDaemon
  • aqemu
  • ...
15725 packages skipped due to time constraints:
  • AusweisApp2
  • CHOWTapeModel
  • DisnixWebService
  • EBTKS
  • EmptyEpsilon
  • Fabric (python38Packages.Fabric)
  • MIDIVisualizer
  • MMA
  • OVMF
  • OVMF-secureBoot
  • ...
7 packages built successfully:
  • audit
  • cryptsetup
  • libfido2
  • libusb1
  • lvm2
  • openssh
  • systemdMinimal
2 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/os-specific/linux/audit/default.nix:74:5:

       |
74 |     license = lib.licenses.gpl2;
   |     ^
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/os-specific/linux/audit/default.nix:76:5:

       |
76 |     maintainers = with lib.maintainers; [ ];
   |     ^

Result of nixpkgs-review pr 123342 at ce801ab7 run on x86_64-linux 1

806 packages marked as broken and skipped:
  • adobe-reader
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • adoptopenjdk-jre-openj9-bin-13
  • adoptopenjdk-jre-openj9-bin-14
  • adoptopenjdk-openj9-bin-13
  • adoptopenjdk-openj9-bin-14
  • agdaPackages.iowa-stdlib
  • ...
2 packages failed to build:
17487 packages skipped due to time constraints:
  • AusweisApp2
  • CHOWTapeModel
  • DisnixWebService
  • EBTKS
  • EmptyEpsilon
  • Fabric (python38Packages.Fabric)
  • MIDIVisualizer
  • MMA
  • OSCAR
  • OVMF
  • ...
25 packages built successfully:
  • at-spi2-atk
  • at-spi2-core
  • audit
  • avahi
  • cryptsetup
  • cups
  • dbus
  • dbus-glib
  • dconf (gnome.dconf ,xfce.dconf)
  • libgudev (gnome.libgudev)
  • tracker (gnome.tracker)
  • libfido2
  • libinput
  • libseat
  • libudev0-shim
  • libusb1
  • libwacom
  • lvm2
  • media-player-info
  • openssh
  • presage
  • python38Packages.pyudev
  • udev (systemd)
  • systemdMinimal
  • wrapGAppsNoGuiHook
2 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/os-specific/linux/audit/default.nix:74:5:

       |
74 |     license = lib.licenses.gpl2;
   |     ^
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/os-specific/linux/audit/default.nix:76:5:

       |
76 |     maintainers = with lib.maintainers; [ ];
   |     ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

SuperSandro2000
SuperSandro2000 requested changes May 17, 2021
View reviewed changes
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented May 17, 2021

/rebase staging

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2021

Failed to rebase

@roblabla roblabla force-pushed the audit-fix-python branch from ce801ab to 06a0be4 Compare May 17, 2021 12:11
SuperSandro2000
SuperSandro2000 requested changes May 18, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR against staging due to the amount of rebuilds.

@roblabla roblabla force-pushed the audit-fix-python branch from 06a0be4 to aee56e4 Compare May 23, 2021 16:15
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. labels May 23, 2021
@roblabla roblabla changed the base branch from master to staging May 23, 2021 16:19
@github-actions github-actions bot removed 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: python Python is a high-level, general-purpose programming language. labels May 23, 2021
@roblabla
Copy link
Contributor Author

roblabla commented May 23, 2021

rebased (sorry for all the noise, should have changed the base branch before pushing the rebase ^^')

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: package (new) This PR adds a new package labels May 23, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. labels May 23, 2021
SuperSandro2000
SuperSandro2000 reviewed May 27, 2021
View reviewed changes
pkgs/os-specific/linux/audit/default.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 May 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prePatch = ''
postPatch = ''

@stale
Copy link

stale bot commented Jan 9, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 9, 2022
@jonringer
Copy link
Contributor

jonringer commented Feb 3, 2022

The diff looks pretty good, if you want to fix the conflicts, I can get this through

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 3, 2022
@roblabla
Copy link
Contributor Author

roblabla commented Feb 3, 2022

I rebased, and it builds locally. Not sure what's up with ofborg's failure?

@jonringer
Copy link
Contributor

jonringer commented Feb 4, 2022 •
edited
Loading

python was made an alias and in the process of being deprecated, I pushed a fix

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 4, 2022

Building git is failing on staging.

@jonringer
Copy link
Contributor

jonringer commented Feb 5, 2022

@GrahamcOfBorg eval

@SuperSandro2000 SuperSandro2000 merged commit e376ad1 into NixOS:staging Feb 7, 2022
@vcunat
Copy link
Member

vcunat commented Mar 15, 2022

This PR broke build of pkgsStatic.audit with

configure: error: no suitable Python interpreter found

and consequently other static packages like nixStatic.

@vcunat vcunat mentioned this pull request Mar 15, 2022
Merged
@roblabla
Copy link
Contributor Author

roblabla commented Mar 16, 2022

Ah, damn! I'll look into it.

@vcunat
Copy link
Member

vcunat commented Mar 27, 2022

For reference, mitigated in PR #164622.

(I'm not sure why GitHub doesn't show a back-reference here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@marsam marsam Awaiting requested review from marsam

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@roblabla @r-rmcgibbo @SuperSandro2000 @jonringer @vcunat