Skip to content

nixos/tests: move makeWrapper to nativeBuildInputs#122204

Merged
roberth merged 1 commit intoNixOS:masterfrom
roberth:nixos-test-expose-driver
May 9, 2021
Merged

nixos/tests: move makeWrapper to nativeBuildInputs#122204
roberth merged 1 commit intoNixOS:masterfrom
roberth:nixos-test-expose-driver

Conversation

@roberth
Copy link
Member

@roberth roberth commented May 8, 2021

Motivation for this change

The main piece was cherry-picked into #122201.
Only a small maintenance commit remains, for strictDeps.

Original description:

With this you can check most scripts with something like

nix-build -A nixosTests.foo.driver

(I've tried to mapAttrs, but it eats too much memory to be practical)

cc @aszlig ~

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 8, 2021
@aszlig
Copy link
Member

aszlig commented May 8, 2021

This could be especially useful for ofborg, since IIRC it doesn't run VM tests without a package change with a linked test or when mentioned expliticly.

@roberth roberth requested a review from andir May 8, 2021 15:44
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 8, 2021
@roberth roberth force-pushed the nixos-test-expose-driver branch from a3d67b4 to 75c4fc1 Compare May 9, 2021 01:04
@roberth roberth changed the title nixos/tests: expose driver nixos/tests: move makeWrapper to nativeBuildInputs May 9, 2021
@roberth
Copy link
Member Author

roberth commented May 9, 2021

@GrahamcOfBorg test sudo

@roberth roberth merged commit ecfc252 into NixOS:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants